Remove some unused(?!) methods on contest_relation#315
Open
bagedevimo wants to merge 1 commit intomigration-versionfrom
Open
Remove some unused(?!) methods on contest_relation#315bagedevimo wants to merge 1 commit intomigration-versionfrom
bagedevimo wants to merge 1 commit intomigration-versionfrom
Conversation
This was referenced Jul 4, 2025
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 4, 2025
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
b131991 to
d69f5b5
Compare
Member
|
alias_method :contest_without_update=, :contest=
alias_method :contest=, :contest_with_update=So it was being used to modify the behaviour of |
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
d69f5b5 to
28e2398
Compare
This was referenced Jul 19, 2025
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
3 times, most recently
from
d68c051 to
3680297
Compare
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
3680297 to
317e3b4
Compare
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
317e3b4 to
a4c34cf
Compare
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
a4c34cf to
5e8ee49
Compare
alias_method_chain is deprecated in Rails 5.0 and removed in Rails 5.1, so we need to stop using it. This allowed us to modify the behaviour of `ContestRelation#contest=` while still providing access to the original method through `contest_without_update=`. But since we weren't using that method anyway, we can just directly override `contest=` instead. Co-authored-by: Jonathan Khoo <jkhoo98@gmail.com>
bagedevimo
force-pushed
the
migration-version
branch
from
e8f59f2 to
11c399d
Compare
bagedevimo
force-pushed
the
remove-contest-finish-at-with
branch
from
5e8ee49 to
3725dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #339
Chain of upstream PRs as of 2025-11-23
PR Add migration version to all prior db migrations #339:
master←migration-versionmigration-version←remove-contest-finish-at-withalias_method_chain is deprecated in Rails 5.0 and removed in Rails 5.1,
so we need to stop using it. I can't find any way these are being
called, unless it ends up being ActiveRecord implict nonsense I can't
find evidence of.