Replace kwargs request specs with params objects#317
Closed
bagedevimo wants to merge 1 commit intopublic-file-serverfrom
Closed
Replace kwargs request specs with params objects#317bagedevimo wants to merge 1 commit intopublic-file-serverfrom
bagedevimo wants to merge 1 commit intopublic-file-serverfrom
Conversation
Deprecated in Rails 5, removed in 5.1.
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 4, 2025
Contributor
|
How does this compare to my commit in rails-5-suggestions-v2? (90ab1e6,
Fix deprecation warning in specs (get/post positional args))
Nit: parans => params, and standardrb doesn't like spaces inside {}.
|
Contributor
|
Re-done in #324. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated in Rails 5, removed in 5.1.