Replace usages of deprecated "uniq" with "distinct"#318
Closed
bagedevimo wants to merge 1 commit intoparams-argsfrom
Closed
Replace usages of deprecated "uniq" with "distinct"#318bagedevimo wants to merge 1 commit intoparams-argsfrom
bagedevimo wants to merge 1 commit intoparams-argsfrom
Conversation
Deprecated in Rails 5, removed in Rails 5.1
This was referenced Jul 4, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
When I attempted this (commit 3903a6c, Switch from 'uniq' to 'distinct' to
fix deprecation warning) I also changed uniq -> distinct in
db/migrate/20131013050536_add_language_id_to_submission.rb because it
seemed like the same thing (even though I didn't get deprecation warnings
for that when running the migrations). What do you think?
Also there is a 'uniq' in app/importers/problems/coci/index.rb which I
didn't touch because it doesn't seem to be on a relation (didn't check
exactly what links_with returns).
|
Contributor
|
Re-done in #324. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated in Rails 5, removed in Rails 5.1