Remove most XML responses

[bagedevimo]

Almost none of these were being used usefully (as checked by a quick
grep of the logs on the server) except for SubmissionController#show,
which I have left in place for now. I also removed all comments refering
to routes, as a great number of them are incorrect and we discussed
briefly on discord and decided to remove. (use bundle exec rake routes
instead. Additionally, a fixed a couple of cases of record#destory being
called instead of record#destroy!. You pretty much always want to use
destroy! - the former version has no errors or warnings if the delete
fails for any reason, which is rarely what you want.

[coveralls]

coverage: 37.743% (-1.0%) from 38.771%
when pulling 8a3e0ff on formats-and-routes
into be26406 on master.

[bagedevimo]

• Upgrade gemfile for Rails 5.0.7.2 #298 : 2 dependent PRs (#314 , #315 )
• Configure the hybrid cookie session store #302
• Write out StrongPresenter #297
• Add basic feature test for problem browsing #300
• Remove the squeel gem #296
• Write out FixturesSpecHelper #290
• Remove most XML responses #292 👈 (View in Graphite)
• Refactor db/seeds to allow for easy development seeds #293
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Holmes98]

If we're keeping this, I'd prefer keeping the .xml syntax if possible rather than changing to ?debug, since it's clearer about the response format and makes it easier for other formats to be added in the future (e.g. JSON). Potentially either of these?

Suggested change

	if params.key?(:debug) && current_user.is_admin?
	render xml: @submission
	else
	render :show
	respond_to do |format|
	format.html # show.html.erb
	format.xml { render xml: @submission } if current_user.is_admin?
	end

Suggested change

	if params.key?(:debug) && current_user.is_admin?
	render xml: @submission
	else
	render :show
	if request.format.xml? && current_user.is_admin?
	render xml: @submission
	else
	render :show

Otherwise I don't mind if we just remove the XML response from here as well for now (I think the cases you found in the logs were probably just me testing that from when you originally asked about this).

[bagedevimo]

Merge activity

• May 18, 9:07 AM EDT: @bagedevimo merged this pull request with Graphite.