Merged
Conversation
This was referenced May 9, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 9, 2025
bagedevimo
force-pushed
the
graphite-base/296
branch
from
61b8521 to
4ce2ff0
Compare
bagedevimo
changed the base branch from
graphite-base/296
to
write-out-fixtures-spec-helper
bagedevimo
force-pushed
the
write-out-fixtures-spec-helper
branch
from
4ce2ff0 to
8a3725d
Compare
bagedevimo
force-pushed
the
write-out-fixtures-spec-helper
branch
from
8a3725d to
f4e1438
Compare
bagedevimo
force-pushed
the
remove-squeel
branch
2 times, most recently
from
aaa6a82 to
d48919d
Compare
bagedevimo
force-pushed
the
write-out-fixtures-spec-helper
branch
from
f4e1438 to
41073c0
Compare
Holmes98
reviewed
May 14, 2025
Member
Holmes98
left a comment
Holmes98
left a comment
There was a problem hiding this comment.
Nice. I've tried to test most of this since our coverage isn't great, just found a few things.
bagedevimo
changed the base branch from
write-out-fixtures-spec-helper
to
graphite-base/296
bagedevimo
force-pushed
the
graphite-base/296
branch
from
41073c0 to
f6ff75b
Compare
bagedevimo
changed the base branch from
graphite-base/296
to
write-out-fixtures-spec-helper
bagedevimo
force-pushed
the
write-out-fixtures-spec-helper
branch
2 times, most recently
from
9078bba to
b48f347
Compare
bagedevimo
force-pushed
the
remove-squeel
branch
2 times, most recently
from
20499c8 to
b20200c
Compare
This gem isn't supported on Rails >= 5, and also fully deprecated. I've replaced all usages of it with the equivalent Rails 4.2 code which isn't necessarily the most ergonomic nor the most performance, in some cases, but should be fine for our cases. I also had to repair one migration that was added back in 2013 and will never be run again, and could theoretically just be commented out, but the fix was trivial.
One of the trickier Squeel removals, so a small spec seemed warranted. The first attempt to rewrite this had a bunch of issues I missed, too.
It's not a huge amount of coverage, but enough to exercise some interesting cases in the policies and controllers.
Holmes98
approved these changes
May 22, 2025
Member
Holmes98
left a comment
Holmes98
left a comment
There was a problem hiding this comment.
Looks good to me. There are a few other places using Relation#merge that I think could be removed (in app/controllers/groups/members_controller.rb and app/models/request.rb), but I guess it doesn't really matter.
Contributor
Author
Merge activity
|
This was referenced Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gem isn't supported on Rails >= 5, and also fully deprecated.