Skip to content

Write out StrongPresenter#297

Merged
bagedevimo merged 1 commit intomasterfrom
remove-strong-presenters
Jun 10, 2025
Merged

Write out StrongPresenter#297
bagedevimo merged 1 commit intomasterfrom
remove-strong-presenters

Conversation

@bagedevimo
Copy link
Contributor

This gem was originally written by Ronald (one of the original authors
of this repo) but now looks to be abandoned and definitely doesn't
support Rails >= 5.0.

Copy link
Contributor Author

bagedevimo commented May 9, 2025

@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 32dab4a to 8742471 Compare May 9, 2025 20:26
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 8742471 to 1bfa5ff Compare May 9, 2025 21:00
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 1bfa5ff to f65b8e1 Compare May 9, 2025 21:41
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from f65b8e1 to d9fcfe6 Compare May 9, 2025 23:17
@bagedevimo bagedevimo changed the base branch from remove-squeel to graphite-base/297 May 13, 2025 09:10
@bagedevimo bagedevimo force-pushed the graphite-base/297 branch from d48919d to 4820445 Compare May 14, 2025 06:53
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from d9fcfe6 to 5fbea5d Compare May 14, 2025 06:53
@bagedevimo bagedevimo changed the base branch from graphite-base/297 to remove-squeel May 14, 2025 06:53
@bagedevimo bagedevimo changed the base branch from remove-squeel to graphite-base/297 May 16, 2025 23:41
@bagedevimo bagedevimo force-pushed the graphite-base/297 branch from 4820445 to 83e25e7 Compare May 21, 2025 12:14
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 5fbea5d to 00ae31b Compare May 21, 2025 12:14
@bagedevimo bagedevimo changed the base branch from graphite-base/297 to problem-browing-spec May 21, 2025 12:14
@bagedevimo bagedevimo changed the title WIP: Write out StrongPresenter Write out StrongPresenter May 21, 2025
@bagedevimo bagedevimo marked this pull request as ready for review May 21, 2025 12:15
@bagedevimo bagedevimo force-pushed the problem-browing-spec branch from 83e25e7 to d7e6e15 Compare May 21, 2025 12:50
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 00ae31b to da92951 Compare May 21, 2025 12:50
@coveralls
Copy link

coveralls commented May 21, 2025

Coverage Status

coverage: 37.578% (-0.4%) from 37.958%
when pulling 3bfbd7d on remove-strong-presenters
into 507b89b on master.

@bagedevimo bagedevimo force-pushed the problem-browing-spec branch from d7e6e15 to ca8c75a Compare May 22, 2025 07:12
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from da92951 to 63bd463 Compare May 22, 2025 07:12
@bagedevimo bagedevimo force-pushed the problem-browing-spec branch from ca8c75a to bc381e3 Compare May 22, 2025 07:17
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from 63bd463 to f4d861e Compare May 22, 2025 07:17
@bagedevimo bagedevimo force-pushed the problem-browing-spec branch 2 times, most recently from b260d5b to c6ca244 Compare May 22, 2025 12:21
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from f4d861e to a145c03 Compare May 22, 2025 12:21
@bagedevimo bagedevimo changed the base branch from problem-browing-spec to graphite-base/297 May 22, 2025 13:30
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from a145c03 to aaca701 Compare May 22, 2025 13:30
@bagedevimo bagedevimo changed the base branch from graphite-base/297 to master May 22, 2025 13:30
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from aaca701 to ffc335e Compare May 22, 2025 13:31
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch 2 times, most recently from ef086d6 to e155405 Compare June 9, 2025 01:24
@bagedevimo bagedevimo requested a review from Holmes98 June 9, 2025 01:33
This gem was originally written by Ronald (one of the original authors
of this repo) but now looks to be abandoned and definitely doesn't
support Rails >= 5.0.

We only had one major usage, which I just replaced by generating the
table manually, which IMO is more readable anyway.
@bagedevimo bagedevimo force-pushed the remove-strong-presenters branch from e155405 to 3bfbd7d Compare June 10, 2025 20:26
@bagedevimo bagedevimo merged commit 8acb0ad into master Jun 10, 2025
7 checks passed
Copy link
Contributor Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants