Conversation
bagedevimo
force-pushed
the
remove-strong-presenters
branch
from
32dab4a to
8742471
Compare
bagedevimo
force-pushed
the
remove-strong-presenters
branch
2 times, most recently
from
1bfa5ff to
f65b8e1
Compare
bagedevimo
force-pushed
the
rails-5
branch
2 times, most recently
from
2522099 to
331f31b
Compare
bagedevimo
force-pushed
the
remove-strong-presenters
branch
2 times, most recently
from
d9fcfe6 to
5fbea5d
Compare
bagedevimo
force-pushed
the
remove-strong-presenters
branch
from
5fbea5d to
00ae31b
Compare
bagedevimo
changed the base branch from
remove-strong-presenters
to
graphite-base/298
bagedevimo
force-pushed
the
graphite-base/298
branch
from
00ae31b to
63bd463
Compare
bagedevimo
changed the base branch from
graphite-base/298
to
remove-strong-presenters
bagedevimo
force-pushed
the
remove-strong-presenters
branch
2 times, most recently
from
f4d861e to
a145c03
Compare
bagedevimo
force-pushed
the
remove-strong-presenters
branch
from
a145c03 to
aaca701
Compare
I hope you don't mind, but I re-worded that app:update commit message even more to try and explain some of my thinking at the time as well as the context you added. I also cherry-picked your :debug -> :info commit onto the top, because the ordering doesn't really matter unless we're planning on doing some kind of weird merge. |
There was a problem hiding this comment.
I hope you don't mind, but I re-worded that app:update commit message even more to try and explain some of my thinking at the time as well as the context you added. I also cherry-picked your :debug -> :info commit onto the top, because the ordering doesn't really matter unless we're planning on doing some kind of weird merge.
Sure. Some more nits for the commit message:
- subject => "Run `rails app:update` and apply changes as required" (fixes typo in the command, for searching/newbies; aside: I had "bin/rails" before but we actually can't do that yet)
- "with out modifications" => "with our modifications"(?)
I've fixed some deprecation warnings in branch "rails-5-suggestions-v2", up to you if you want to do it in this PR or a different one.
There are still a couple of warnings, including two that we'll need to fix before we upgrade to 5.1:
- "#table_exists? currently checks both tables and views. This behavior is deprecated and will be changed with Rails 5.1 to only check tables. Use #data_source_exists? instead."
- "before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead."
|
applied your suggestions to the commit message, thanks! yeah keen AF to merge this then start the fast-follow fixing deprecations and warnings - I have a grep ready for scanning the log files. |
Rails 5 removed these features from core, instead using a seperate gem. rails/rails#21161
assert_template has been removed (extracted?) to a new gem,
rails-controller-test. We use this all over the place, so this should
just work.
> Failure/Error: expect(response).to render_template("pages/forum")
> NoMethodError:
> assert_template has been extracted to a gem. To continue using it,
> add `gem 'rails-controller-testing'` to your Gemfile.
Simple form added support for Rails 5 in 3.2.1, but only actually fixed bugs introduced by Rails 5 in 3.3.1: https://github.com/heartcombo/simple_form/blob/main/CHANGELOG.md#331
This presumably used to work in the prior versions of Rails or rails-controller-test, but no longer does.
The environment configuration in config/environments/*.rb hasn't been updated to the rails defaults with our modifications, as there are a lot of individual changes and this is best left for future discussions and changes. Especially in the context of another ~8 rails versions to upgrade to get anywhere near the latest, there will be a lot of churn in those files and minimising that where possible is the goal here.
Rails 5 changes the ruby schema format to exclude the indexes from the table creates, and a few other minor changes. This final is completely generated, so it's not really something we need to review, which is why I put it in a separate commit.
Rails 5 changed this to no longer be a prepend, per the devise docs: https://github.com/heartcombo/devise/pull/4033/files
The default will change to :debug in Rails 5, and then back to :info in Rails 6.1. Set it to :info explicitly to get stable behaviour. (The comment mentioning personally-identifiable information is copied from the Rails 8 template.) References: https://guides.rubyonrails.org/v5.0.0/upgrading_ruby_on_rails.html#production-log-level https://www.github.com/rails/rails/pull/39707
This file is deleted later in the Rails upgrade series, so it feels a bit silly to add it now. Additionally, having it be present with a different value to the values we set for test and development elsewhere causes annoying and silly issues when switching branches while we develop and review this branch.
We aren't currently using it, and the recent update in #298 seems to have introduced issues with Qless spawning extra worker processes.
We aren't currently using it, and the recent update in #298 seems to have introduced issues with Qless spawning extra worker processes.
4 participants
Upgrade gemfile for Rails 5.0.7.2
Add activemodel-serializers-xml to Gemfile
Rails 5 removed these features from core, instead using a seperate gem.
rails/rails#21161