Skip to content

Conversation

@daveey
Copy link
Contributor

@daveey daveey commented Jan 17, 2026

Add C++ implementations for event system filters and mutations:

Filters (handler_config.hpp + filter.hpp):

  • ObjectTypeFilterConfig + ObjectTypeFilter: Check if object has a specific tag
  • CollectiveFilterConfig + CollectiveFilter: Check if object belongs to collective
  • BoundaryFilterConfig + BoundaryFilter: Check if at boundary between collectives
    (Note: adjacency check is a TODO pending grid neighbor iteration)

Mutations (handler_config.hpp + mutation.hpp):

  • AlignToCollectiveMutationConfig + AlignToCollectiveMutation: Align to named collective
  • StatsMutationConfig + StatsMutation: Log stat with delta

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

Add C++ implementations for event system filters and mutations:

Filters (handler_config.hpp + filter.hpp):
- ObjectTypeFilterConfig + ObjectTypeFilter: Check if object has a specific tag
- CollectiveFilterConfig + CollectiveFilter: Check if object belongs to collective
- BoundaryFilterConfig + BoundaryFilter: Check if at boundary between collectives
  (Note: adjacency check is a TODO pending grid neighbor iteration)

Mutations (handler_config.hpp + mutation.hpp):
- AlignToCollectiveMutationConfig + AlignToCollectiveMutation: Align to named collective
- StatsMutationConfig + StatsMutation: Log stat with delta

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor Author

daveey commented Jan 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@blacksmith-sh
Copy link

blacksmith-sh bot commented Jan 17, 2026

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.cc View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.cc View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.cc View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.h View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.h View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.h View Logs

Fix in Cursor

@datadog-official
Copy link

datadog-official bot commented Jan 17, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 253 Tests failed

    TestActionOrdering::test_action_indices_consistency from test_action_compatibility.py (Fix with Cursor)

    TestActionOrdering::test_action_order_is_fixed from test_action_compatibility.py (Fix with Cursor)

    TestActionSpace::test_action_space_shape from test_action_compatibility.py (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 913db07 | Docs | Was this helpful? Give us feedback!

@openhands-ai
Copy link

openhands-ai bot commented Jan 17, 2026

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Test and Benchmark

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #4961 at branch `01-16-feat_mettagrid_add_c_filter_and_mutation_implementations_for_events`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@daveey daveey changed the base branch from 01-16-test_mettagrid_add_integration_tests_for_events_system to graphite-base/4961 January 17, 2026 04:30
@daveey daveey closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants