Skip to content

Conversation

@daveey
Copy link
Contributor

@daveey daveey commented Jan 17, 2026

Add AlignToCollectiveMutation that aligns target to a specific collective by name.
Unlike AlignmentMutation (which aligns to actor's collective), this allows direct
alignment to any named collective - useful for events that don't have an actor.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

Copy link
Contributor Author

daveey commented Jan 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@blacksmith-sh

This comment has been minimized.

@datadog-official

This comment has been minimized.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b509f8f519

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from 89bfaf4 to cdb5d2d Compare January 17, 2026 04:30
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch 2 times, most recently from a79ebd0 to 4a8d25d Compare January 17, 2026 04:37
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from cdb5d2d to 162ef91 Compare January 17, 2026 04:37
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch from 4a8d25d to 04ce093 Compare January 17, 2026 04:42
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from 162ef91 to 2ea8636 Compare January 17, 2026 04:42
@daveey daveey changed the base branch from 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored to graphite-base/4957 January 17, 2026 04:49
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch from 04ce093 to 22299ef Compare January 17, 2026 04:52
@daveey daveey force-pushed the graphite-base/4957 branch from 2ea8636 to 3155039 Compare January 17, 2026 04:52
@daveey daveey changed the base branch from graphite-base/4957 to 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored January 17, 2026 04:52
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from 3155039 to cc254e0 Compare January 17, 2026 05:07
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch 2 times, most recently from 0403df0 to fb85dab Compare January 17, 2026 05:17
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch 2 times, most recently from 75cd391 to e04bec5 Compare January 17, 2026 05:19
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch 2 times, most recently from 139a420 to 6c3fee4 Compare January 17, 2026 05:25
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from e04bec5 to 094c395 Compare January 17, 2026 05:25
@daveey daveey requested a review from sasmith January 17, 2026 05:37
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from 094c395 to fd2d361 Compare January 17, 2026 05:43
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch 2 times, most recently from 59c2983 to 731c8af Compare January 17, 2026 07:04
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored branch from fd2d361 to 54f81b3 Compare January 17, 2026 07:04
…alignment

Add AlignToCollectiveMutation that aligns target to a specific collective by name.
Unlike AlignmentMutation (which aligns to actor's collective), this allows direct
alignment to any named collective - useful for events that don't have an actor.

Python:
- AlignToCollectiveMutationConfig with mutation_type="align_to_collective" and collective field
- AlignToCollective() helper function
- Added to AnyMutation union

C++:
- AlignToCollectiveMutationConfig struct in handler_config.hpp
- AlignToCollectiveMutation class in mutation.hpp with set_collective() method
- Added to MutationConfig variant

Tests:
- test_align_to_collective_mutation.py with creation, helper, serialization tests

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@daveey daveey changed the base branch from 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored to graphite-base/4957 January 18, 2026 05:33
@daveey daveey force-pushed the 01-16-feat_mettagrid_add_aligntocollectivemutation_for_direct_collective_alignment_add_aligntocollectivemutation_that_aligns_target_to_a_specific_collective_by_name._unlike_alignmentmutation_which_aligns_to_actor_s_collective_this_all branch from 731c8af to 15bac33 Compare January 18, 2026 05:41
@daveey daveey force-pushed the graphite-base/4957 branch from 54f81b3 to 83c898c Compare January 18, 2026 05:41
@daveey daveey changed the base branch from graphite-base/4957 to 01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored January 18, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants