feat(mettagrid): add CollectiveFilter for filtering by collective membership #4956
+398
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
daveey
commented
Jan 17, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89bfaf4216
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jan 17, 2026
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
89bfaf4 to
cdb5d2d
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
2 times, most recently
from
9386e8d to
c025c5f
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
cdb5d2d to
162ef91
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
c025c5f to
76dc6a7
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
162ef91 to
2ea8636
Compare
daveey
changed the base branch from
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
to
graphite-base/4956
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
2ea8636 to
3155039
Compare
daveey
force-pushed
the
graphite-base/4956
branch
from
76dc6a7 to
f2eb41e
Compare
daveey
changed the base branch from
graphite-base/4956
to
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
3155039 to
cc254e0
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
f2eb41e to
af6dca4
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
cc254e0 to
75cd391
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
af6dca4 to
1c95e70
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
75cd391 to
e04bec5
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
2 times, most recently
from
2fdbe93 to
b0f9602
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
e04bec5 to
094c395
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
b0f9602 to
481ff9d
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
094c395 to
fd2d361
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
481ff9d to
93ddb90
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
fd2d361 to
54f81b3
Compare
daveey
commented
Jan 18, 2026
| } | ||
|
|
||
| // Check if the collective name matches | ||
| return coll->name == _config.collective_name; |
daveey
changed the base branch from
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
to
graphite-base/4956
…bership Add CollectiveFilter that checks if target belongs to a specific collective. Used by events to select objects by their collective membership. Python: - CollectiveFilterConfig with filter_type="collective" and collective field - BelongsToCollective() helper function - Added to AnyFilter union C++: - CollectiveFilterConfig struct in handler_config.hpp - CollectiveFilter class in filter.hpp - Added to FilterConfig variant Tests: - test_collective_filter.py with creation, helper, serialization tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
daveey
force-pushed
the
graphite-base/4956
branch
from
93ddb90 to
8adb6df
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_collectivefilter_for_filtering_by_collective_membership_add_collectivefilter_that_checks_if_target_belongs_to_a_specific_collective._used_by_events_to_select_objects_by_their_collective_membership._co-authored
branch
from
54f81b3 to
83c898c
Compare
daveey
changed the base branch from
graphite-base/4956
to
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CollectiveFilter that checks if target belongs to a specific collective.
Used by events to select objects by their collective membership.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com