Skip to content

Conversation

@daveey
Copy link
Contributor

@daveey daveey commented Jan 17, 2026

refactor(mettagrid): remove clipper system

Remove the clipper system entirely from mettagrid and cogames.
This is preparation for replacing it with a more general events system.

Changes:

  • Remove Clipper class and ClipperConfig from C++ codebase
  • Remove clipper from Python config classes
  • Remove clip_period, start_clipped, clip_immune fields from assemblers
  • Remove clipping-related missions (RepairMission, HelloWorldUnclipMission)
  • Remove clipping-related variants (ClipHubStationsVariant, ClipPeriodOnVariant, etc.)
  • Remove unclipping diagnostic evals
  • Update tests to remove clipping assertions

Note: Scripted agents that reference clipping will need separate cleanup.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

refactor(nim): remove clipping references from Nim agents

Remove clipped field from ObservedObject and ExtractorInfo types,
remove clipped feature parsing from common.nim, and remove unclipping
evals from thinky_eval.py.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

Copy link
Contributor Author

daveey commented Jan 17, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@blacksmith-sh

This comment has been minimized.

@datadog-official
Copy link

datadog-official bot commented Jan 17, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a8ff769 | Docs | Was this helpful? Give us feedback!

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa999282c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daveey daveey force-pushed the 01-16-refactor_mettagrid_remove_clipper_system branch 3 times, most recently from 653be6e to c9aa87b Compare January 17, 2026 05:25
@openhands-ai
Copy link

openhands-ai bot commented Jan 17, 2026

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Test and Benchmark

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #4953 at branch `01-16-refactor_mettagrid_remove_clipper_system`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@daveey daveey force-pushed the 01-16-refactor_mettagrid_remove_clipper_system branch from c9aa87b to e1f2146 Compare January 17, 2026 05:34
daveey and others added 2 commits January 17, 2026 20:37
Remove the clipper system entirely from mettagrid and cogames.
This is preparation for replacing it with a more general events system.

Changes:
- Remove Clipper class and ClipperConfig from C++ codebase
- Remove clipper from Python config classes
- Remove clip_period, start_clipped, clip_immune fields from assemblers
- Remove clipping-related missions (RepairMission, HelloWorldUnclipMission)
- Remove clipping-related variants (ClipHubStationsVariant, ClipPeriodOnVariant, etc.)
- Remove unclipping diagnostic evals
- Update tests to remove clipping assertions

Note: Scripted agents that reference clipping will need separate cleanup.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove clipped field from ObservedObject and ExtractorInfo types,
remove clipped feature parsing from common.nim, and remove unclipping
evals from thinky_eval.py.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants