-
Notifications
You must be signed in to change notification settings - Fork 47
refactor(mettagrid): remove clipper system #4953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa999282c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aa99928 to
4c32137
Compare
653be6e to
c9aa87b
Compare
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
c9aa87b to
e1f2146
Compare
Remove the clipper system entirely from mettagrid and cogames. This is preparation for replacing it with a more general events system. Changes: - Remove Clipper class and ClipperConfig from C++ codebase - Remove clipper from Python config classes - Remove clip_period, start_clipped, clip_immune fields from assemblers - Remove clipping-related missions (RepairMission, HelloWorldUnclipMission) - Remove clipping-related variants (ClipHubStationsVariant, ClipPeriodOnVariant, etc.) - Remove unclipping diagnostic evals - Update tests to remove clipping assertions Note: Scripted agents that reference clipping will need separate cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove clipped field from ObservedObject and ExtractorInfo types, remove clipped feature parsing from common.nim, and remove unclipping evals from thinky_eval.py. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
e1f2146 to
a8ff769
Compare

refactor(mettagrid): remove clipper system
Remove the clipper system entirely from mettagrid and cogames.
This is preparation for replacing it with a more general events system.
Changes:
Note: Scripted agents that reference clipping will need separate cleanup.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
refactor(nim): remove clipping references from Nim agents
Remove clipped field from ObservedObject and ExtractorInfo types,
remove clipped feature parsing from common.nim, and remove unclipping
evals from thinky_eval.py.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com