feat(mettagrid): add BoundaryFilter for filtering objects at collective boundaries #4959
+158
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 873027b844
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 17, 2026
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
873027b to
bed664d
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
2 times, most recently
from
40b8869 to
cfd9196
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
bed664d to
54094ca
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
from
cfd9196 to
717b742
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
54094ca to
17ab37e
Compare
daveey
changed the base branch from
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
to
graphite-base/4959
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
17ab37e to
aba6974
Compare
daveey
force-pushed
the
graphite-base/4959
branch
from
717b742 to
14d48ae
Compare
daveey
changed the base branch from
graphite-base/4959
to
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
aba6974 to
a671ff1
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
from
14d48ae to
cb22d29
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
a671ff1 to
817e45c
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
2 times, most recently
from
46a0e5c to
32c29a2
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
817e45c to
12a5ea7
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
12a5ea7 to
aafa6cf
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
from
32c29a2 to
a64686c
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
aafa6cf to
c6c113e
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
branch
2 times, most recently
from
6c64e32 to
110061e
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
c6c113e to
924a56d
Compare
daveey
commented
Jan 18, 2026
| @@ -0,0 +1,282 @@ | |||
| # Mechanic-Based Curriculum Design | |||
…ve boundaries Add BoundaryFilter that checks if target is at the boundary between two collectives. Passes if target belongs to collective_a AND is adjacent to collective_b. Python: - BoundaryFilterConfig with filter_type="boundary", collective_a, collective_b fields - AtBoundary() helper function - Added to AnyFilter union C++: - BoundaryFilterConfig struct in handler_config.hpp - BoundaryFilter class in filter.hpp with AdjacencyCallback for grid integration - Added to FilterConfig variant Tests: - test_boundary_filter.py with creation, helper, serialization tests Note: Adjacency checking requires grid integration via set_adjacency_callback(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
daveey
changed the base branch from
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
to
graphite-base/4959
Design for automatic curriculum that promotes game mechanics: - Threshold-based graduation - Random selection from ungraduated mechanics - Scaffolding removal after graduation - Configurable batch size Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
daveey
force-pushed
the
graphite-base/4959
branch
from
110061e to
232df60
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_boundaryfilter_for_filtering_objects_at_collective_boundaries_add_boundaryfilter_that_checks_if_target_is_at_the_boundary_between_two_collectives._this_is_the_python_config_side_c_adjacency_tracking_implementa
branch
from
924a56d to
1958dbd
Compare
daveey
changed the base branch from
graphite-base/4959
to
01-16-feat_mettagrid_add_statsmutation_for_logging_stats_add_statsmutation_that_logs_a_stat_with_a_specified_delta._useful_for_events_to_track_when_they_fire_or_record_custom_metrics._co-authored-by_claude_opus_4.5_noreply_anthropic.c
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BoundaryFilter that checks if target is at the boundary between two collectives.
This is the Python config side; C++ adjacency tracking implementation will follow.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com