feat(mettagrid): add ObjectTypeFilter for filtering by object type #4955
+289
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 17, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
daveey
commented
Jan 17, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41ed8caf3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jan 17, 2026
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
2 times, most recently
from
9386e8d to
c025c5f
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
78c9396 to
adf7819
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
c025c5f to
76dc6a7
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
adf7819 to
4809cc6
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
76dc6a7 to
f2eb41e
Compare
daveey
changed the base branch from
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
to
graphite-base/4955
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
f2eb41e to
af6dca4
Compare
daveey
force-pushed
the
graphite-base/4955
branch
from
4809cc6 to
166d42d
Compare
daveey
changed the base branch from
graphite-base/4955
to
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
166d42d to
7643db3
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
2 times, most recently
from
1c95e70 to
2fdbe93
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
7643db3 to
7d6268b
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
7d6268b to
a726bae
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
2fdbe93 to
b0f9602
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
from
a726bae to
f9a8d61
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
2 times, most recently
from
481ff9d to
93ddb90
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
branch
2 times, most recently
from
4fca1f2 to
17b2c02
Compare
daveey
changed the base branch from
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
to
graphite-base/4955
Add ObjectTypeFilter that checks if target has a specific tag. Used by events to select which objects to apply mutations to. Python: - ObjectTypeFilterConfig with filter_type="object_type" and tag field - HasTag() helper function - Added to AnyFilter union C++: - ObjectTypeFilterConfig struct in handler_config.hpp - ObjectTypeFilter class in filter.hpp - Added to FilterConfig variant Tests: - test_object_type_filter.py with creation, helper, serialization tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
daveey
force-pushed
the
graphite-base/4955
branch
from
4fca1f2 to
c2870e9
Compare
daveey
force-pushed
the
01-16-feat_mettagrid_add_objecttypefilter_for_filtering_by_object_type_add_objecttypefilter_that_checks_if_target_has_a_specific_tag._used_by_events_to_select_which_objects_to_apply_mutations_to._co-authored-by_claude_opus_4.5_noreply
branch
from
93ddb90 to
8adb6df
Compare
daveey
changed the base branch from
graphite-base/4955
to
01-16-feat_mettagrid_add_events_system_core_infrastructure_add_eventconfig_class_for_timestep-based_events_that_apply_mutations_to_filtered_objects._events_can_target_any_gridobject_and_include_-_timesteps_list_of_timesteps_when_event
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ObjectTypeFilter that checks if target has a specific tag.
Used by events to select which objects to apply mutations to.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com