Remove unused DurationBeforeChangeTierRequestDeletion config#515
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 7-8: Remove the temporary personal-fork replace directive "replace
github.com/codeready-toolchain/api => github.com/rajivnathan/api ..." before
merging; instead wait for the upstream PR codeready-toolchain/api#499 to be
merged and then update the existing require entry for
"github.com/codeready-toolchain/api" (the require on line 31) to the official
new pseudo-version, and delete the replace directive so consumers resolve the
canonical module.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
go.modpkg/test/config/toolchainconfig.go
💤 Files with no reviewable changes (1)
- pkg/test/config/toolchainconfig.go
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
7-8:⚠️ Potential issue | 🟠 MajorRemove the personal-fork
replacebefore merge.This still redirects the canonical module to a personal fork, which can unintentionally ship non-official dependency resolution to consumers. Keep this only as a local/dev workaround, not in
master.#!/bin/bash # Verify the personal-fork replace is gone before merge rg -nP '^\s*replace\s+github\.com/codeready-toolchain/api\s*=>\s*github\.com/rajivnathan/api' go.mod # Verify canonical dependency is still explicitly required rg -nP '^\s*github\.com/codeready-toolchain/api\s+v' go.modAs per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 7 - 8, Remove the personal-fork replace directive that maps github.com/codeready-toolchain/api => github.com/rajivnathan/api in go.mod; delete the replace line and ensure the canonical module github.com/codeready-toolchain/api is still present as a required dependency (keep or add the proper released version) so dependency resolution uses the official upstream module rather than a personal fork; run `go mod tidy` locally to update go.sum and verify no remaining replace entries referencing github.com/rajivnathan/api.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Around line 7-8: Remove the personal-fork replace directive that maps
github.com/codeready-toolchain/api => github.com/rajivnathan/api in go.mod;
delete the replace line and ensure the canonical module
github.com/codeready-toolchain/api is still present as a required dependency
(keep or add the proper released version) so dependency resolution uses the
official upstream module rather than a personal fork; run `go mod tidy` locally
to update go.sum and verify no remaining replace entries referencing
github.com/rajivnathan/api.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
go.mod
…mon into removeDurationBeforeChangeTierRequestDeletionCmn
…thub.com:rajivnathan/toolchain-common into removeDurationBeforeChangeTierRequestDeletionCmn
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
7-7:⚠️ Potential issue | 🟠 MajorRemove the personal-fork
replacebefore merge.Line 7 forces all builds to resolve
github.com/codeready-toolchain/apifromgithub.com/rajivnathan/api, which is a supply-chain and maintainability risk formaster. Keep this only as a local/dev override; for merge, remove thereplaceand bump the canonicalrequireon Line 31 once upstream is available.Suggested minimal diff
-replace github.com/codeready-toolchain/api => github.com/rajivnathan/api v0.0.0-20260225164436-80c782ea57deAs per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 7, Remove the temporary go.mod "replace" that points github.com/codeready-toolchain/api to github.com/rajivnathan/api (the replace directive added in the diff); keep that override only locally, not in the merge. After upstream publishes the needed version, delete the replace directive and update the module's require entry for github.com/codeready-toolchain/api to the official upstream version (bump the require version currently present) so builds resolve from the canonical module instead of the personal fork.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Line 7: Remove the temporary go.mod "replace" that points
github.com/codeready-toolchain/api to github.com/rajivnathan/api (the replace
directive added in the diff); keep that override only locally, not in the merge.
After upstream publishes the needed version, delete the replace directive and
update the module's require entry for github.com/codeready-toolchain/api to the
official upstream version (bump the require version currently present) so builds
resolve from the canonical module instead of the personal fork.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
2 participants
Related to codeready-toolchain/api#499
Summary by CodeRabbit