Remove unused DurationBeforeChangeTierRequestDeletion config#578
Conversation
WalkthroughUpdated two dependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 3-5: Remove the personal-fork replace directives in go.mod that
point to github.com/rajivnathan/api and github.com/rajivnathan/toolchain-common;
revert these to the upstream modules (remove or update the replace lines) and
ensure the require block references the intended upstream versions (or wait for
upstream PRs to land and then update requires), so dependency resolution does
not rely on personal forks.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
…service into removeDurationBeforeCTRDeletionMemberRgSvc
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
3-6:⚠️ Potential issue | 🔴 CriticalPipeline failure blocks merge: personal fork
replacedirectives not allowed.The CI check explicitly rejects these
replacedirectives with exit code 1. These must be removed before merge can proceed. Once the upstream PRs (api#499, toolchain-common#515) are merged, update therequireblock to reference the new upstream versions and remove thesereplacelines.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 3 - 6, Remove the temporary local fork overrides in go.mod: delete the two replace directives referencing github.com/rajivnathan/api and github.com/rajivnathan/toolchain-common, then update the require block to point to the new upstream versions produced by the merged PRs (api PR `#499` and toolchain-common PR `#515`) so the module uses the official upstream module versions instead of local fork replacements; ensure go mod tidy is run to update go.sum and vendor if used.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Around line 3-6: Remove the temporary local fork overrides in go.mod: delete
the two replace directives referencing github.com/rajivnathan/api and
github.com/rajivnathan/toolchain-common, then update the require block to point
to the new upstream versions produced by the merged PRs (api PR `#499` and
toolchain-common PR `#515`) so the module uses the official upstream module
versions instead of local fork replacements; ensure go mod tidy is run to update
go.sum and vendor if used.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 9-10: The go.mod entry for module
github.com/codeready-toolchain/api references a non-existent commit hash
(912fcbd23dc7); locate the correct commit hash in the upstream
codeready-toolchain/api repo that corresponds to PR `#499` (the change removing
DurationBeforeChangeTierRequestDeletion) and replace the current hash on the
github.com/codeready-toolchain/api line in go.mod with that valid commit version
so the dependency resolves correctly (leave the toolchain-common line
unchanged).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7 | ||
| github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Verifying upstream commits exist ==="
# Check codeready-toolchain/api commit 912fcbd23dc7
echo "Checking github.com/codeready-toolchain/api commit 912fcbd23dc7..."
if curl -fsS "https://api.github.com/repos/codeready-toolchain/api/commits/912fcbd23dc7" >/dev/null 2>&1; then
echo "✓ api commit 912fcbd23dc7 exists"
# Get commit message to verify it's related to the expected change
curl -fsS "https://api.github.com/repos/codeready-toolchain/api/commits/912fcbd23dc7" | \
jq -r '.commit.message' | head -5
else
echo "✗ api commit 912fcbd23dc7 not found"
fi
echo ""
# Check codeready-toolchain/toolchain-common commit d7d5d0163ff7
echo "Checking github.com/codeready-toolchain/toolchain-common commit d7d5d0163ff7..."
if curl -fsS "https://api.github.com/repos/codeready-toolchain/toolchain-common/commits/d7d5d0163ff7" >/dev/null 2>&1; then
echo "✓ toolchain-common commit d7d5d0163ff7 exists"
# Get commit message to verify it's related to the expected change
curl -fsS "https://api.github.com/repos/codeready-toolchain/toolchain-common/commits/d7d5d0163ff7" | \
jq -r '.commit.message' | head -5
else
echo "✗ toolchain-common commit d7d5d0163ff7 not found"
fiRepository: codeready-toolchain/registration-service
Length of output: 504
The api dependency commit does not exist in the upstream repository.
The commit hash for github.com/codeready-toolchain/api (912fcbd23dc7) cannot be found in the upstream repo. The toolchain-common commit (d7d5d0163ff7) exists and correctly removes the DurationBeforeChangeTierRequestDeletion config, but it references an invalid api dependency update.
Verify the correct api commit hash that corresponds to PR #499 (removing the unused config) and update line 9 accordingly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 9 - 10, The go.mod entry for module
github.com/codeready-toolchain/api references a non-existent commit hash
(912fcbd23dc7); locate the correct commit hash in the upstream
codeready-toolchain/api repo that corresponds to PR `#499` (the change removing
DurationBeforeChangeTierRequestDeletion) and replace the current hash on the
github.com/codeready-toolchain/api line in go.mod with that valid commit version
so the dependency resolves correctly (leave the toolchain-common line
unchanged).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rajivnathan
merged commit e2561e0
into
codeready-toolchain:master
3 participants
Related to codeready-toolchain/api#499 and codeready-toolchain/toolchain-common#515
Summary by CodeRabbit