Remove unused DurationBeforeChangeTierRequestDeletion config#730
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 3-5: Remove the temporary local fork replace directives for
github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common from go.mod (the two "replace"
entries pointing to github.com/rajivnathan/*) and update the corresponding
"require" entries for those modules to the official canonical pseudoversions
produced by the upstream merges (api#499 and toolchain-common#515); after
updating, run go mod tidy to ensure module graph is consistent and the
ci-check-gomod pipeline will pass.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
…or into removeDurationBeforeCTRDeletionMember
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
3-5:⚠️ Potential issue | 🔴 CriticalRemove temporary personal-fork
replacedirectives before merge.Line 3 and Line 5 pin canonical dependencies to a personal fork, which is risky for mainline reproducibility and typically breaks governance/CI expectations for released branches.
🐛 Proposed fix
-replace github.com/codeready-toolchain/api => github.com/rajivnathan/api v0.0.0-20260225164436-80c782ea57de - -replace github.com/codeready-toolchain/toolchain-common => github.com/rajivnathan/toolchain-common v0.0.0-20260225170920-5096cffa010b#!/bin/bash # Verify no personal-fork replace directives remain in go.mod rg -n '^replace github.com/codeready-toolchain/(api|toolchain-common)\s*=>\s*github.com/rajivnathan/' go.mod # Expected result: no matchesAs per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 3 - 5, The go.mod contains temporary personal-fork replace directives pointing github.com/codeready-toolchain/api and github.com/codeready-toolchain/toolchain-common to github.com/rajivnathan/* which must be removed before merge; open go.mod and delete the two replace lines that start with "replace github.com/codeready-toolchain/api => github.com/rajivnathan/..." and "replace github.com/codeready-toolchain/toolchain-common => github.com/rajivnathan/..." (or restore them to the canonical module versions), then run `go mod tidy` to update the module graph and confirm no remaining personal-fork replaces for those modules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Around line 3-5: The go.mod contains temporary personal-fork replace
directives pointing github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common to github.com/rajivnathan/*
which must be removed before merge; open go.mod and delete the two replace lines
that start with "replace github.com/codeready-toolchain/api =>
github.com/rajivnathan/..." and "replace
github.com/codeready-toolchain/toolchain-common => github.com/rajivnathan/..."
(or restore them to the canonical module versions), then run `go mod tidy` to
update the module graph and confirm no remaining personal-fork replaces for
those modules.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rajivnathan
merged commit a838bdf
into
codeready-toolchain:master
2 participants
Related to codeready-toolchain/api#499 and codeready-toolchain/toolchain-common#515
Summary by CodeRabbit