Skip to content

Remove unused DurationBeforeChangeTierRequestDeletion config#1239

Merged
rajivnathan merged 3 commits intocodeready-toolchain:masterfrom
rajivnathan:removeDurationBeforeCTRDeletionHost
Feb 26, 2026
Merged

Remove unused DurationBeforeChangeTierRequestDeletion config#1239
rajivnathan merged 3 commits intocodeready-toolchain:masterfrom
rajivnathan:removeDurationBeforeCTRDeletionHost

Conversation

@rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Feb 25, 2026

Related to codeready-toolchain/api#499 and codeready-toolchain/toolchain-common#515

Summary by CodeRabbit

  • Bug Fixes

    • Removed the duration-based tier request deletion configuration option from ToolchainConfig, streamlining tier management settings.
  • Chores

    • Updated internal dependencies to improve compatibility and reliability.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5b9f0 and 98834d6.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Walkthrough

Removed the durationBeforeChangeTierRequestDeletion field from the ToolchainConfig CRD schema and updated two module requirement versions in go.mod for github.com/codeready-toolchain/api and github.com/codeready-toolchain/toolchain-common.

Changes

Cohort / File(s) Summary
CRD Schema Updates
config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml
Removed the durationBeforeChangeTierRequestDeletion field (description and type removal) from the defaultUserTier section of the ToolchainConfig CRD.
Module Requirement Updates
go.mod
Updated require versions: github.com/codeready-toolchain/apiv0.0.0-20260226033043-912fcbd23dc7; github.com/codeready-toolchain/toolchain-commonv0.0.0-20260226040150-d7d5d0163ff7.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing the unused DurationBeforeChangeTierRequestDeletion configuration field, which matches the primary modification shown in the CRD schema.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Around line 3-5: Remove the disallowed replace directives from go.mod: delete
the two replace entries for github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common; instead update the require
statements to point to published module versions or upstream commit/tags (or
land your unpublished changes upstream and then bump require to the official
version) so ci-check-gomod no longer fails due to replace directives.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3c07b92 and 1cd98b5.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml
  • controllers/toolchainconfig/configuration.go
  • controllers/toolchainconfig/configuration_test.go
  • go.mod
💤 Files with no reviewable changes (3)
  • controllers/toolchainconfig/configuration.go
  • config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml
  • controllers/toolchainconfig/configuration_test.go

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

@rajivnathan rajivnathan merged commit 0cd3510 into codeready-toolchain:master Feb 26, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants