Remove unused DurationBeforeChangeTierRequestDeletion config#1239
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 3-5: Remove the disallowed replace directives from go.mod: delete
the two replace entries for github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common; instead update the require
statements to point to published module versions or upstream commit/tags (or
land your unpublished changes upstream and then bump require to the official
version) so ci-check-gomod no longer fails due to replace directives.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yamlcontrollers/toolchainconfig/configuration.gocontrollers/toolchainconfig/configuration_test.gogo.mod
💤 Files with no reviewable changes (3)
- controllers/toolchainconfig/configuration.go
- config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml
- controllers/toolchainconfig/configuration_test.go
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… into removeDurationBeforeCTRDeletionHost
|
0cd3510
into
codeready-toolchain:master



Related to codeready-toolchain/api#499 and codeready-toolchain/toolchain-common#515
Summary by CodeRabbit
Bug Fixes
Chores