Remove unused DurationBeforeChangeTierRequestDeletion config#1258
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
WalkthroughUpdated dependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 3-5: The go.mod contains invalid replace directives for
github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common that point to non-existent
commits in rajivnathan/api and rajivnathan/toolchain-common; remove or correct
these replace lines so the build can resolve dependencies: either delete the two
replace directives, change them to valid upstream module versions (e.g., a
released tag/commit present in the upstream repos for
github.com/codeready-toolchain/api and
github.com/codeready-toolchain/toolchain-common), or switch to a local
development setup (go.work) if you need to test local forks—update the replace
entries only with verifiable module versions or remove them entirely.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
… into updateRmvDurationBeforeChangeTierRequestDeletion
| require ( | ||
| github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de | ||
| github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2 | ||
| github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7 |
There was a problem hiding this comment.
Should we delete durationBeforeChangeTierRequestDeletion in the deploy/host-operator toolchainconfig.yml files?
There was a problem hiding this comment.
Yes, thank you! Great catch! You are better than coderabbit! 😁 bc0f431
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rajivnathan
merged commit 8834e88
into
codeready-toolchain:master
2 participants
Related to codeready-toolchain/api#499 and codeready-toolchain/toolchain-common#515
Summary by CodeRabbit
Chores
Configuration