feat: WC-274 component can opt for CMS styles #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing might be overkill. It passed before the fix was added.
to help in debugging solution to hot reload error in dev
KNOWN ISSUES: Does not make CMS content look exactly correct.
KNOWN ISSUE: CMS content still does not render perfect.
3 tasks
cuz it is using portal basic text color instead of cms basic text color
TO DO: - Make footer conditional. - Fix footer position. BREAKING CHANGE: Footer always shown. Footer position is wrong.
TODO: - reduce redundant code
The style does not support disabled attribute. AI suggested media attribute. Unexpected, but sensible.
core-styles.cms.css provides it
TACC/Core-CMS-Custom#494 And those updates made to templates on PPRD DigitalRocks.
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Jul 3, 2025
probably related to task.digital-rocks being behind main
This reverts commit 90890d2.
probably related to task.digital-rocks being behind main
probably related to task.digital-rocks being behind main
Bootstrap v5 changes `data-` attributes for these features. Modals and Dropdowns require new naming.
Related to previous commit
These are cruft from CMS script that changes HTML elements which Django CMS did not allow me to put in a snippet.
…external-styles-sans-conflict-for-a-component
shayanaijaz
approved these changes
Jul 8, 2025
Contributor
shayanaijaz
left a comment
shayanaijaz
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the updates
shayanaijaz
deleted the
feat/WC-274-allow-dpm-to-load-external-styles-sans-conflict-for-a-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To allow a component to use CMS styles instead of Portal styles.
Why?
WC-219 was styled for CMS, but is being developed within Portal.
End goal:
task/digital-rocksto wrap DPM components (to toggle CMS UI)Important
DPM-specific styles (and sample components) are in #1135.
Note
New components in this branch do not have test cases.
Tip
Failing checks are mostly from target branch.
Status
tasks already completed
hint: check alignment of elements
DataFilesForDPM.global.cssbleedfixassume code coverage errors are related to DPM codeMight be Bootstrap v4 (CMS) vs v5 (Portal) attr issue.
feat: WC-274 component can opt for CMS styles - DPM styles & sample components #1135
Related
Changes
CMSWrappercomponentCMSBreadcrumbscomponent stubindex.cssinportalCSS layertooltipstylesbase.htmlCSS into CSS layersTesting
See #1135.
UI
See #1135.