feat: WC-274 component can opt for CMS styles - DPM styles & sample components #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing might be overkill. It passed before the fix was added.
to help in debugging solution to hot reload error in dev
KNOWN ISSUES: Does not make CMS content look exactly correct.
KNOWN ISSUE: CMS content still does not render perfect.
cuz it is using portal basic text color instead of cms basic text color
TO DO: - Make footer conditional. - Fix footer position. BREAKING CHANGE: Footer always shown. Footer position is wrong.
TODO: - reduce redundant code
The style does not support disabled attribute. AI suggested media attribute. Unexpected, but sensible.
TACC/Core-CMS-Custom#494 And those updates made to templates on PPRD DigitalRocks.
probably related to task.digital-rocks being behind main
This reverts commit 90890d2.
probably related to task.digital-rocks being behind main
probably related to task.digital-rocks being behind main
Bootstrap v5 changes `data-` attributes for these features. Modals and Dropdowns require new naming.
Related to previous commit
These are cruft from CMS script that changes HTML elements which Django CMS did not allow me to put in a snippet.
This reverts commit e0916df.
20 tasks
wesleyboar
changed the title
wesleyboar
changed the base branch from
main
to
feat/WC-274-allow-dpm-to-load-external-styles-sans-conflict-for-a-component
Base automatically changed from
feat/WC-274-allow-dpm-to-load-external-styles-sans-conflict-for-a-component
to
task/digital-rocks
July 8, 2025 21:07
…external-styles-sans-conflict-for-a-component--sample-components
…external-styles-sans-conflict-for-a-component--sample-components
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Already integrated (I think via 884836d). See #1137 for latest code as of 2025-08-21.
Overview / Changes
Add required DPM-specific styles and sample DPM components.
Important
Isolated for reference and testing.
Caution
Remember to add DPM-specific styles from this PR to DPM branch
task/digital-rocks.Related
Testing
UI
Quick Test Video (2025-06-27)
dpm.cms.ui.test.fast.mov
Dynamic Footer (2025-06-24)
CMS.Styles.Load.mov
CMS.Styles.Unload.mov
Compare Styles to CMS (2025-06-27)