Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jun 20, 2025

Overview

Allow footer markup to be loaded from /cms/markup/footer.

Important

Is that what we want the path to be?

Why?

So WC-274 can also load footer content from CMS.

Related

Changes

  • moved footer to its own template
  • deleted footer block
    Unused. And footer can instead be replaced by overwriting template.
  • added url to access footer

Testing

  1. Verify CMS with no custom footer content:
    • loads default footer on any page
    • serves default footer's markup at /cms/markup/footer
  2. Verify CMS with any custom footer content:
    • loads custom footer on any page
    • serves custom footer's markup at /cms/markup/footer

UI

Before
markup
markup BEFORE
After
script content network request
javascript AFTER network request AFTER

@wesleyboar wesleyboar marked this pull request as ready for review June 24, 2025 00:18
@wesleyboar wesleyboar requested review from rstijerina and taoteg June 24, 2025 00:21
@rstijerina
Copy link
Member

Just checking - is it a sticky footer?

@wesleyboar
Copy link
Member Author

@rstijerina, N/A; this merely provides the footer markup, no styles.

The footer's position relative to the app that could load it (Portal) is to be defined by the app. Positioning the footer after being loaded from CMS is a remaining challenge (a checkbox task under "Status") in TACC/Core-Portal#1127.

@wesleyboar
Copy link
Member Author

wesleyboar commented Jun 24, 2025

@rstijerina, @taoteg Any thoughts on the path name?

Existing such paths are:

  • cms/nav/pages/markup/
  • cms/header/branding/markup/
  • cms/header/logo/markup/

But I propose:

  • 🆕 cms/markup/footer
  • cms/markup/nav
  • cms/markup/branding
  • cms/markup/logo

If a pattern change is acceptable, I will update the others.

@taoteg
Copy link
Contributor

taoteg commented Jun 24, 2025

I like the clarity fo the proposed path updates with the markup prefix. Unless there is some technical reason to oppose it,I think it makes sense.

@wesleyboar wesleyboar merged commit 1f9e94f into main Jun 24, 2025
@wesleyboar wesleyboar deleted the feat/WC-274-serve-footer-markup branch June 24, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants