fix(digitalrocks): updates since Core-Styles v2.45 #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
added a commit
to TACC/Core-Portal
that referenced
this pull request
Jul 3, 2025
TACC/Core-CMS-Custom#494 And those updates made to templates on PPRD DigitalRocks.
Core-Portal has aclone. Maybe I can make this DRY. For now, fix.
shayanaijaz
added a commit
to TACC/Core-Portal
that referenced
this pull request
Jul 8, 2025
* feat: WC-219 isolate external styles for component * fix: WC-219 change hook ext from jsx to js * fix: WC-219 fix hot reload error, add test The testing might be overkill. It passed before the fix was added. * refactor: WC-219 organize code more cleanly to help in debugging solution to hot reload error in dev * refactor: WC-219 change solution from DOM to CSS KNOWN ISSUES: Does not make CMS content look exactly correct. * chore: WC-219 remove cruft * feat: WC-219 hide navbar, simplify cms content CSS KNOWN ISSUE: CMS content still does not render perfect. * feat: WC-219 match test CMS content perfectly * chore: WC-219 delete shadow dom attempt * refactor: WC-219 rename files * fix: WC-219 missing part of "rename files" commit * chore: WC-219 delete outdated import * fix: WC-219 attrname vs attrName in JSX * fix: WC-219 file accidentally deleted * refactor: WC-219 extract breadcrumbs * fix: header styles overwritten by mimic-cms styles * fix: basic text color too dark cuz it is using portal basic text color instead of cms basic text color * feat!: footer from CMS TO DO: - Make footer conditional. - Fix footer position. BREAKING CHANGE: Footer always shown. Footer position is wrong. * refactor: cms-footer ID changed to just footer * chore: remove unused class * feat: only load CMS footer when necessary * docs: "make CMS styles conditional like … footer" * feat: "make CMS styles conditional like … footer" TODO: - reduce redundant code * docs: delete "make CMS styles conditional …" * fix: move DataFiles CSS back to DataFiles * refactor: simplify cms_styles.html * fix: cms_styles not disabled The style does not support disabled attribute. AI suggested media attribute. Unexpected, but sensible. * chore: restore new line * chore: simplify DataFiles…Breadcrumbs * refactor: CMSWrapper * refactor: clean up so DPM usage is clearer * chore: use `latest` cms image again v4.31.0 (latest) includes the new feature * fix: does not match CMS UI exactly Return CMS code to after <head>, which React/Vite appends with CSS that cms_styles must overwrite. * refactor cms_styles → cms_ui * chore: npm prettier--write client * chore: npm run lint:css * fix: footer on CMS layout * chore: remove duplicate code * chore: remove stray `async` keyword * fix: CMS footer present upon return to regular Portal * fix: DataFilesForDPM.global.css bleed * feat: CMSWrapper useDynamicStylesheets * refactor: move <main> to CMSWrapper only * chore: npm prettier --write client * docs: remove pagination comment * chore: comment format * test: other sample content * feat: navigate sample content * fix: remove tab-content/pane styles * fix: image url and attr whitepsace * fix: whtiespace between HTML tags for DPMRead * chore: npm prettier --write client * fix: misaligned image in <div> missing `container` Also added on design: - https://pprd.digitalrocks.tacc.utexas.edu/datasets/317/ - https://pprd.digitalrocks.tacc.utexas.edu/datasets/218/ * fix: wrong markup for heading Also fixed in design: - https://pprd.digitalrocks.tacc.utexas.edu/datasets/317/ - https://pprd.digitalrocks.tacc.utexas.edu/datasets/218/ * fix: nested container alignement mimics a CMS idiosyncrasy * chore: npm prettier --write client * fix: missing spaces * fix: misaligned nested container * fix: poetry lock * fix: do not import s-footer twice core-styles.cms.css provides it * fix: mirror TACC/Core-CMS-Custom#494 updates TACC/Core-CMS-Custom#494 And those updates made to templates on PPRD DigitalRocks. * deps: Core-Styles v2.45 * enhance: migrate styles from CDN to here * refactor: reorg styles so CMS can load 'em cleanly * chore: use latest corestyles, if used via CDN * chore: core-cms v4.33 via latest * fix: manually revert unintentional change probably related to task.digital-rocks being behind main * Revert "fix: manually revert unintentional change" This reverts commit 90890d2. * fix: condifently revert unintentional changes probably related to task.digital-rocks being behind main * fix: delete stray file probably related to task.digital-rocks being behind main * fix: inaccurate href value * fix: modals, dropdowns, tabs (new bootstrap, v5) Bootstrap v5 changes `data-` attributes for these features. Modals and Dropdowns require new naming. * fix: missing modals data- attr update Related to previous commit * chore: remove `data-tag-change-from` attributes These are cruft from CMS script that changes HTML elements which Django CMS did not allow me to put in a snippet. * fix: tooltips * fix: modal content styles * fix: limit portal modal content styles to portal * fix: dropdown styles * refactor: delete sample components + their styles --------- Co-authored-by: Shayan Khan <skhan@tacc.utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates since Core-Syles v2.45 migrated styles from digital rocks.
Related
Changes
cms.csstobrowse-datasets.cssu-summary-link-mergedtou-summary-with-a-linkc-data-list__row--start-finalTesting
No reference. @wesleyboar will do this by memory.
UI
Skipped. Visit https://pprd.digitalrocks.tacc.utexas.edu/datasets/ and explore.