chore: refresh all dependencies and eliminate need for --legacy-peer-deps
#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
This was referenced Oct 30, 2025
laurelfulford
approved these changes
Nov 3, 2025
laurelfulford
left a comment
laurelfulford
left a comment
There was a problem hiding this comment.
Giving a shared 👍 based on @chickenn00dle and my testing!
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This updates as many shared dependencies as possible to the latest compatible versions. It also applies linting to this repo's own code using the same configs as it shares with other Newspack repos that consume it as an NPM package.
Also deprecates the separate
typescript:checkscript used by dependent repos for TS type checking. In my testing, the newer version of@wordpress/eslint-pluginperforms type checking via ESLint if you let it run on.ts|.tsxfiles, making the separate script redundant. However, I've left thetypescript:checkscript code and its dependencies intact here just in case, so we can remove them at a future date once we're absolutely certain we don't need them.Incidentally, updating all dependencies to the latest versions seems to have resolved most unresolvable peer dependency conflicts, so using
--legacy-peer-depsshould no longer be necessary in dependent Newspack repos.How to test the changes in this Pull Request:
This can't be tested here, as the changes affect dependent Newspack repos that consume this repo as an NPM package. But before we publish these changes as a new package version, we can test the changes in those other repos by installing
newspack-scriptsfrom this branch usingnpm i Automattic/newspack-scripts#chore\/refresh-dependencies --save-dev.I've done this for all of our major repos and opened PRs for testing. Once we've successfully tested each dependent repo, we can publish the changes to NPM and then update the version number in each PR before merging to complete the updates.
Testing for each PR should be as follows:
npm startornpm ci(no--legacy-peer-deps!). You may need to delete thenode_modulesdirectory first, I'm not sure if this is strictly required but I'll mention it just in case.npm run buildandnpm run watchand confirm that the assets build successfullynpm run lintand confirm that SCSS and JS linting worksnpm run typescript:checkscript is deprecated and removed from dependent repos. Instead, confirm thatnpm run lint:jsperforms TypeScript checks and report results along with other JS linting results. (This is easiest to confirm withnewspack-plugin, which should return some non-blocking TS warnings.)npm run testand confirm that JS unit tests work (only applicable if the repo has any)npm run semantic-release --dry-runand confirm there's successful outputOther information: