Skip to content

Conversation

@leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Run PHPCS on PHP 7.4 to avoid Fatal errors. See WordPress/WordPress-Coding-Standards@7cd46be

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner July 6, 2023 13:19
@dkoo
Copy link
Contributor

dkoo commented Aug 29, 2023

Should we just merge this and let it run on other repos?

@leogermani
Copy link
Contributor Author

Well, actually -> https://make.wordpress.org/core/2023/08/21/wordpresscs-3-0-0-is-now-available

At some point I think we can upgrade and it should work fine with php 8

@dkoo
Copy link
Contributor

dkoo commented Nov 4, 2025

@leogermani looks like phpunit is still working well as of #219. Do we still need to update anything on the PHP testing side?

@leogermani
Copy link
Contributor Author

@leogermani looks like phpunit is still working well as of #219. Do we still need to update anything on the PHP testing side?

I don't really remember what this was about but I guess it's not relevant anymore. We have been running php tests in all repos just fine...

@leogermani leogermani closed this Nov 4, 2025
@dkoo
Copy link
Contributor

dkoo commented Nov 4, 2025

Closing!

@dkoo dkoo reopened this Nov 4, 2025
@dkoo dkoo closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants