Skip to content

Conversation

@dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 30, 2025

All Submissions:

Changes proposed in this Pull Request:

See Automattic/newspack-scripts#219.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor

laurelfulford commented Oct 31, 2025

I've just crossed out the scripts that this repo doesn't have:

  • Run npm start or npm ci (no --legacy-peer-deps!)
  • Confirm that the install completes successfully
    Run npm run build and npm run watch and confirm that the assets build successfully
    Run npm run lint and confirm that SCSS and JS linting works
    Run npm run test and confirm that JS unit tests work (only applicable if the repo has any)
  • Run npm run semantic-release --dry-run and confirm there's successful output
  • Smoke test both WP admin and front-end functionality—there should be no significant changes

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of what was available to test in this plugin, everything tested well!

@dkoo dkoo marked this pull request as ready for review November 3, 2025 18:31
@dkoo dkoo requested a review from a team as a code owner November 3, 2025 18:31
@dkoo dkoo merged commit a28ebd2 into trunk Nov 3, 2025
1 check passed
@dkoo dkoo deleted the chore/update-dependencies-oct-2025 branch November 3, 2025 18:32
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants