-
Notifications
You must be signed in to change notification settings - Fork 9
chore: update dependencies (oct 2025) #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part this looks good! I just spotted one odd thing when I went from the post editor to the brands (Post editor > Brands panel > Manage brands):
That's this page: /wp-admin/admin.php?page=newspack-multi-branded-sites
If I go from Newspack > Settings > Additional Brands, it looks normal (that's wp-admin/admin.php?page=newspack-settings#/additional-brands).
When I follow the initial path on trunk (Post editor > Brands panel > Manage brands link), the page looks normal (with no gap, and with a white background rather than grey).
I can't see anything that stands out as the issue - there isn't a unique JS error on this branch that isn't present on trunk. I also get this when I'm also running the updated dependancies branch of the Newspack Plugin.
This feels minor (I'm not sure how often people go from the post editor to that screen) and the Multibranded settings are functional from there, though the gap/grey background persist on the other screens.
Just let me know if you have any questions about this!
|
@laurelfulford it took me a little while to figure out that the 5b0ab82 adds a check and redirects the standalone page URL to the Newspack Plugin settings page if available, and updates the "Manage brands" link in the editor sidebar too. It also adds some light CSS fixes for the standalone page to make the background white and remove the gap, but really it's an edge case to use the plugin without the main Newspack Plugin, so I didn't focus too much on it. |
laurelfulford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dkoo! That was a weird one -- I thought it was a style thing since the page looked different on trunk and in this branch but that also didn't really make sense 🙂
This loos good now, and I double-checked the plugin without Newspack Plugin active for good measure. All the screens look great! 🚢
|
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
|
🎉 This PR is included in version 2.2.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
See Automattic/newspack-scripts#219.
Other information: