Skip to content

Conversation

@dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 29, 2025

All Submissions:

Changes proposed in this Pull Request:

See Automattic/newspack-scripts#219.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo requested a review from a team as a code owner October 29, 2025 21:37
@dkoo dkoo marked this pull request as draft October 29, 2025 21:37
@chickenn00dle
Copy link

chickenn00dle commented Oct 30, 2025

  • Run npm start or npm ci (no --legacy-peer-deps!)
  • Confirm that the install completes successfully
  • Run npm run build and npm run watch and confirm that the assets build successfully
  • Run npm run lint and confirm that SCSS and JS linting works
  • Run npm run test and confirm that JS unit tests work (only applicable if the repo has any)
  • Run npm run semantic-release --dry-run and confirm there's successful output
  • Smoke test both WP admin and front-end functionality—there should be no significant changes

Copy link

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but noting I'm not really confident in my smoke tests here. Since this is not released to our publishers yet though, gonna approve.

@dkoo
Copy link
Contributor Author

dkoo commented Oct 30, 2025

@thomasguillot, can I ask you to smoke test this since you're most familiar with the Block Theme?

@dkoo dkoo requested a review from thomasguillot October 30, 2025 20:51
@thomasguillot
Copy link
Contributor

thomasguillot commented Oct 31, 2025

Worked fine 🚬

@dkoo dkoo marked this pull request as ready for review November 3, 2025 18:18
@dkoo dkoo merged commit 86a0d80 into trunk Nov 3, 2025
1 of 2 checks passed
@dkoo dkoo deleted the chore/update-dependencies-oct-2025 branch November 3, 2025 18:21
@matticbot
Copy link

🎉 This PR is included in version 1.22.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants