[release-4.19] OCPBUGS-61662: Add API validation to reject # or whitespace in spec.path #2012
Conversation
This commit introduces api validation to reject # or whitespace in the spec.path. This is becaause it causes HaProxy error and the inress to become degraded. The validation will reject any new route that tries to create with whitespace or # in spec.path. It will allow for ratcheting. Test cases are also introduced in the validation_test.go file Related bug: https://issues.redhat.com/browse/OCPBUGS-47773
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-47773 has been cloned as Jira Issue OCPBUGS-61662. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61662, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@lihongan: This pull request references Jira Issue OCPBUGS-61662, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@lihongan: This pull request references Jira Issue OCPBUGS-61662, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign |
|
/assign |
|
This is a clean cherry-pick. @Thealisyed don't forget to create the followup PR in openshift/apiserver. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 2dd58eb
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-61662: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-61662 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ShudiLi: Jira Issue OCPBUGS-61662: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-61662 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
|
Fix included in accepted release 4.19.0-0.nightly-2025-12-19-215710 |
|
/cherry-pick release-4.18 |
|
@Thealisyed: new pull request created: #2117 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
This is an automated cherry-pick of #1958
/assign Thealisyed