API validation: reject # or whitespace in spec.path #2123
Conversation
This commit introduces api validation to reject # or whitespace in the spec.path. This is becaause it causes HaProxy error and the inress to become degraded. The validation will reject any new route that tries to create with whitespace or # in spec.path. It will allow for ratcheting. Test cases are also introduced in the validation_test.go file Related bug: https://issues.redhat.com/browse/OCPBUGS-47773
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Thealisyed The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Thealisyed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
#or whitespace characters inspec.pathvalidatePathfunction and integrate it withValidateRouteandValidateRouteUpdateThis ensures routes with invalid path characters that would cause HAProxy errors are rejected at the API level.
Related bug: https://issues.redhat.com/browse/OCPBUGS-47773
Cherry-picked from #2012 with tests included.
Assisted with Claude