OCPBUGS-47773: Bump library-go to fix route validation #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
jira/severity-important
|
@rikatz: This pull request references Jira Issue OCPBUGS-47773, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
Author
|
/cc @Miciah |
Member
Author
|
/hold Running some local tests before unholding |
openshift-ci
bot
added
the
do-not-merge/hold
rikatz
force-pushed
the
bump-library-go-for-route-validation
branch
from
ab8dd24 to
d5b5470
Compare
Member
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
|
Thanks! /lgtm |
Miciah
reviewed
Aug 14, 2025
| } | ||
| return allErrs | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The changes in this file are the changes from openshift/library-go#1958 that motivated the library-go bump.
Comment on lines
+472
to
+473
| // The router service account needs to be granted with read-only access to this secret, | ||
| // please refer to openshift docs for additional details. |
Contributor
There was a problem hiding this comment.
FYI @chiragkyal, this vendors at last the changes from openshift/api#2159.
Comment on lines
+274
to
+276
| tls.TLS_AES_128_GCM_SHA256, | ||
| tls.TLS_AES_256_GCM_SHA384, | ||
| tls.TLS_CHACHA20_POLY1305_SHA256, |
Contributor
There was a problem hiding this comment.
@tiraboschi, this vendor bump pulls in the changes from openshift/library-go#1956. Is that going to impact the openshift-apiserver TLS configuration?
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
the failing tests seems to be the same on both pipelines, and are related to metrics gathering. Will try one more retest |
Member
Author
|
/retest |
rikatz
force-pushed
the
bump-library-go-for-route-validation
branch
from
d5b5470 to
7a1cb55
Compare
Member
Author
|
The metric gathering failure seems very much like kubernetes/kubernetes#131234 but I am not sure how to get this onto the job, so I will retest for now and come back to it later /retest |
Contributor
|
Looks like kubernetes/kubernetes#131234 is being tracked as OCPBUGS-57477. |
Contributor
|
/lgtm |
Member
|
I technically don’t have approval permission here but @sanchezl or @dgrisonnet can do it. Please do so. Thanks |
sanchezl
approved these changes
Aug 19, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, Miciah, rikatz, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
This other test regression is being tracked at OCPBUGS-59836 |
Member
Author
|
/test e2e-aws-ovn-serial-2of2 |
Contributor
|
@rikatz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@rikatz: Jira Issue OCPBUGS-47773: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-47773 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@Thealisyed: #535 failed to apply on top of branch "release-4.19": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Thealisyed we need firstly merge openshift/library-go#2012 then bump to 4.19. I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.