[release-4.18] OCPBUGS-74235: Add API validation to reject # or whitespace in spec.path

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2012

/assign Thealisyed

[openshift-ci-robot]

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-61662 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-74235: Add API validation to reject # or whitespace in spec.path

Details

In response to this:

This is an automated cherry-pick of #2012

/assign Thealisyed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-74235, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-61662 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-61662 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2012

/assign Thealisyed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[benluddy]

/lgtm

[benluddy]

/approve
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: benluddy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/route/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Thealisyed]

Launched a WIP PR in apiserver to test changes
invalid1.yaml

  apiVersion: route.openshift.io/v1                                                                                                                                                                                
  kind: Route                                                                                                                                                                                                    
  metadata:
    name: test-route-hash
    annotations:
      haproxy.router.openshift.io/rewrite-target: /
  spec:
    path: "/test-path#invalid"
    to:
      kind: Service
      name: test-svc
    port:
      targetPort: 8080
    tls:
      termination: edge

invalid2.yaml

  apiVersion: route.openshift.io/v1                                                                                                                                                                                
  kind: Route                                                                                                                                                                                                      
  metadata:                                                                                                                                                                                                        
    name: test-route-space
    annotations:
      haproxy.router.openshift.io/rewrite-target: /
  spec:
    path: "/test path with spaces"
    to:
      kind: Service
      name: test-svc
    port:
      targetPort: 8080
    tls:
      termination: edge

valid.yaml

  apiVersion: route.openshift.io/v1
  kind: Route
  metadata:
    name: test-route-valid
    annotations:
      haproxy.router.openshift.io/rewrite-target: /
  spec:
    path: "/valid-path"
    to:
      kind: Service
      name: test-svc
    port:
      targetPort: 8080
    tls:
      termination: edge

[Thealisyed]

 oc get co ingress

NAME      VERSION                                                AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.20.0-0-2026-02-09-112846-test-ci-ln-0540hcb-latest   True        False         False      84m     

oc new-project test-validation
  oc create service clusterip test-svc --tcp=8080:8080

Already on project "test-validation" on server "https://api.ci-ln-0540hcb-72292.gcp-2.ci.openshift.org:6443".

You can add applications to this project with the 'new-app' command. For example, try:

    oc new-app rails-postgresql-example

to build a new example application in Ruby. Or use kubectl to deploy a simple Kubernetes application:

    kubectl create deployment hello-node --image=registry.k8s.io/e2e-test-images/agnhost:2.43 -- /agnhost serve-hostname

service/test-svc created

oc apply -f invalid1.yaml
The Route "test-route-hash" is invalid: spec.path: Invalid value: "/test-path#invalid": cannot contain # or spaces

oc get routes
No resources found in test-validation namespace.

oc get co ingress

NAME      VERSION                                                AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.20.0-0-2026-02-09-112846-test-ci-ln-0540hcb-latest   True        False         False      85m     

oc apply -f valid.yaml   
route.route.openshift.io/test-route-valid created

oc get routes

NAME               HOST/PORT                                                                          PATH          SERVICES   PORT   TERMINATION   WILDCARD
test-route-valid   test-route-valid-test-validation.apps.ci-ln-0540hcb-72292.gcp-2.ci.openshift.org   /valid-path   test-svc   8080   edge          None


oc get co ingress
NAME      VERSION                                                AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.20.0-0-2026-02-09-112846-test-ci-ln-0540hcb-latest   True        False         False      86m

[candita]

@Thealisyed let's talk about the testing. It looks like your testing version 4.20.0-0-2026-02-09-112846-test-ci-ln-0540hcb-latest in #2117 (comment).