Skip to content

OCPBUGS-13547: Ensure --payload-version is set for MCO on bootstrap #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 17, 2023
Merged

OCPBUGS-13547: Ensure --payload-version is set for MCO on bootstrap #7160

openshift-merge-robot merged 1 commit into from
May 17, 2023

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented May 3, 2023 •
edited
Loading

In tandem with openshift/machine-config-operator#3701 and working towards openshift/machine-config-operator#3688, I am introducing a --payload-version requirement for the render command for MCO, so that it can read feature gates on bootstrap.

/hold

I want to prove with cluster-bot that this works before merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@openshift-ci openshift-ci bot requested review from jhixson74 and rna-afk May 3, 2023 16:19
@JoelSpeed JoelSpeed force-pushed the mco-bootstrap-release-version branch from 27e037b to 4a3cffe Compare May 9, 2023 10:43
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 10, 2023

/retest

@JoelSpeed JoelSpeed force-pushed the mco-bootstrap-release-version branch from 4a3cffe to 0eda453 Compare May 15, 2023 07:26
@JoelSpeed JoelSpeed changed the title Ensure RELEASE_VERSION is set for MCO on bootstrap OCPBUGS-13547: Ensure --payload-version is set for MCO on bootstrap May 15, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2023

@JoelSpeed: This pull request references Jira Issue OCPBUGS-13547, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In tendem with openshift/machine-config-operator#3688, I am introducing a RELEASE_VERSION requirement for the render command for MCO, so that it can read feature gates on bootstrap.

/hold

I want to prove with cluster-bot that this works before merging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 May 15, 2023 07:27
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 15, 2023

/hold cancel

MCO first part has merged, this should be good to go

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2023

@JoelSpeed: This pull request references Jira Issue OCPBUGS-13547, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

In tandem with openshift/machine-config-operator#3701 and working towards openshift/machine-config-operator#3688, I am introducing a --payload-version requirement for the render command for MCO, so that it can read feature gates on bootstrap.

/hold

I want to prove with cluster-bot that this works before merging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 15, 2023

Reviewing the logs of the AWS failure the feature gate yaml manifests aren't rendered correctly, there's no status in them, which has caused KAS and KCM renders to fail before we even get to my change

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 16, 2023

/retest

@sinnykumari
Copy link
Contributor

sinnykumari commented May 16, 2023

LGTM, will wait to see test run passing.

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 16, 2023

Cluster install has passed on the e2e-aws-ovn run, so I think this change should be good to go

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 16, 2023
Merged
@sinnykumari
Copy link
Contributor

sinnykumari commented May 16, 2023

thanks Joel!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented May 16, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
This was referenced May 16, 2023
Merged
Merged
Merged
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2023

/retest-required

Remaining retests: 0 against base HEAD 5d7b657 and 2 for PR HEAD 0eda453 in total

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 16, 2023
Merged
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 16, 2023

/test e2e-aws-ovn

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 16, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 0eda453 link false /test okd-e2e-aws-ovn
ci/prow/e2e-agent-ha-dualstack 0eda453 link false /test e2e-agent-ha-dualstack
ci/prow/okd-e2e-aws-ovn-upgrade 0eda453 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 0eda453 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 35eb0d0 into openshift:master May 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2023

@JoelSpeed: Jira Issue OCPBUGS-13547: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13547 has been moved to the MODIFIED state.

Details

In response to this:

In tandem with openshift/machine-config-operator#3701 and working towards openshift/machine-config-operator#3688, I am introducing a --payload-version requirement for the render command for MCO, so that it can read feature gates on bootstrap.

/hold

I want to prove with cluster-bot that this works before merging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari sinnykumari mentioned this pull request May 17, 2023
Merged
@JoelSpeed JoelSpeed deleted the mco-bootstrap-release-version branch May 17, 2023 08:51
@JoelSpeed JoelSpeed mentioned this pull request May 17, 2023
Merged
4 tasks
This was referenced May 30, 2023
Merged
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rna-afk rna-afk Awaiting requested review from rna-afk

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoelSpeed @openshift-ci-robot @sinnykumari @patrickdillon @openshift-merge-robot