OCPBUGS-13547: Pass release image version to MCO bootstrap via --payload-version

[JoelSpeed]

What this PR does / why we need it:

MCO recently introduced a new flag --payload-version that expects to take the payload release version as a value. This is currently inert but will be required once openshift/machine-config-operator#3688 is merged.
This was added to the installer in openshift/installer#7160.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-13547, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

MCO recently introduced a new flag --payload-version that expects to take the payload release version as a value. This is currently inert but will be required once openshift/machine-config-operator#3688 is merged.
This was added to the installer in openshift/installer#7160.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sjenning]

you can just use imageProvider.Version() here and the previous changes are not required

[csrwng]

/approve

The mcoBootstrapScript is a codepath we no longer use, so we should eventually remove it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/test verify

[enxebre]

capturing slack discussion:
For the nodepool upgrade test we boot them from PreviousReleaseImage.. There's a precedent for the same problematic scenario where MCO flags are not backward compatible #1781.
We need to consolidate this new flag with that code some how, e.g. continue with the fallback approach or may be having specific versions checks. Also we need to raise this to MCO so they can consider new flags to not be that disruptive.
Let's include a version check for now and then sync with mco to explore making new flags less disruptive.

lgtm

[JoelSpeed]

Looks to me like the API server went down for a bit during this test, not sure if this is expected to pass or not, will retest
/test e2e-kubevirt-aws-ovn

[csrwng]

/lgtm
thx!

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2bbe22d and 2 for PR HEAD 54b9bad in total

[openshift-ci]

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-aws-ovn	54b9bad	link	false	/test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@JoelSpeed: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:

• openshift/cluster-cloud-controller-manager-operator#249
• openshift/machine-config-operator#3701
• openshift/installer#7160
• openshift/installer#7189

The following pull requests linked via external trackers have not merged:

• openshift/machine-config-operator#3688 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:

MCO recently introduced a new flag --payload-version that expects to take the payload release version as a value. This is currently inert but will be required once openshift/machine-config-operator#3688 is merged.
This was added to the installer in openshift/installer#7160.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.