-
Notifications
You must be signed in to change notification settings - Fork 591
OCPBUGS-13547: Promote Azure CCM from TPNU to default #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-13547: Promote Azure CCM from TPNU to default #1461
Conversation
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-13547, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
d90da9d to
28ab4e4
Compare
28ab4e4 to
fd4b533
Compare
fd4b533 to
f0635d8
Compare
f0635d8 to
0c571a3
Compare
0c571a3 to
f395c47
Compare
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is good to go, proof in openshift/cluster-config-operator#307 (comment) |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR promotes the Azure CCM feature gate from TechPreviewNoUpgrade to default.
Will need to be proven with payload tests against config-operator before we merge