OCPBUGS-13547: Require consistency in rendered artifacts #299
Conversation
openshift-ci
bot
added
the
approved
|
/hold proof of openshift/library-go#1516 |
openshift-ci
bot
added
the
do-not-merge/hold
|
/payload 4.14 nightly informing |
|
@deads2k: trigger 55 job(s) of type informing for the nightly release of OCP 4.14
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28a79850-e860-11ed-9d10-565524584e21-0 |
pkg/cmd/render/render.go
Outdated
|
|
||
| var prev *genericrenderoptions.RenderedManifest | ||
| var featureGate *configv1.FeatureGate | ||
| for i := range featureGates { |
There was a problem hiding this comment.
Why not use GetManifest() introduced in openshift/library-go#1516? Seems it would provide the same functionality since we know FeatureGate is a singleton in the cluster
deads2k
force-pushed
the
require-consistency
branch
from
77fe3ea to
ac668ec
Compare
|
updated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
deads2k
added
the
bugzilla/valid-bug
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-operator-container-v4.14.0-202305021815.p0.gba949c8.assembly.stream for distgit ose-cluster-config-operator. |
|
This broke Hypershift CI |
deads2k
changed the title
|
@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
adds a check for those consuming rendered manifests that none of the contents conflict. Conflicts would result in unpredictable results on the cluster.