RFC 45-3: Use protocol for video codec selections #8088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2023
tytan652
force-pushed
the
use_protocol_for_codecs
branch
from
90a5aee to
0da1467
Compare
6 tasks
tytan652
force-pushed
the
use_protocol_for_codecs
branch
from
0da1467 to
cb1a0d1
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
3 times, most recently
from
c666c8a to
8fe43ab
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
4 times, most recently
from
7799914 to
a8f55c6
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
4 times, most recently
from
08ce2fe to
97403c7
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
2 times, most recently
from
e9fa36d to
9e74f3c
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
2 times, most recently
from
26a2ce6 to
0e6e8ce
Compare
Collaborator
Author
|
Remove prefix related changes as it was done in the RFC. |
tytan652
force-pushed
the
use_protocol_for_codecs
branch
6 times, most recently
from
e7bc1b1 to
7db4483
Compare
tytan652
force-pushed
the
use_protocol_for_codecs
branch
4 times, most recently
from
3ef0d8a to
d2f0535
Compare
If the server URL is not an RTMP(S) URL, the protocol field becomes required. The output field becomes required on non-RTMP(S) services to keep backward compatibility. Also skip service if the protocol is not available.
The fallback in now inside the output.
MPEG-TS standard is not ready for AV1
tytan652
force-pushed
the
use_protocol_for_codecs
branch
from
d2f0535 to
e317c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about the RFC 45.
Depends on:
Make OBS Studio rely on the notion of protocol and service compatibility to enable some codec to be used with the stream service.
Motivation and Context
Part of the implementation of the RFC 45.
Remove the hardcoded list and allow AV1 on SRT/RIST once MPEG-TS has it's standard ready.
How Has This Been Tested?
Changing services and check if codecs shown match with compatible ones.
Types of changes
Checklist: