-
-
Notifications
You must be signed in to change notification settings - Fork 9k
RFC 45-6: Enable more connection info in Services API #8095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
11e86e9 to
a45384c
Compare
a45384c to
8410661
Compare
|
Rebased on #8090 to be able to work on top of all RFC 45 PRs. |
0bafab7 to
4715222
Compare
4e5a563 to
ec186bf
Compare
57a1900 to
0ab1ee9
Compare
4e5ad21 to
82af445
Compare
c276303 to
5acbfbb
Compare
|
Remove prefix related changes as it was done in the RFC. |
The fallback in now inside the output.
MPEG-TS standard is not ready for AV1
Also remove Opus-only "supported audio codecs" in the services JSON.
Also refactors AAC bitrate map too.
This replace and deprecate url, key, username and password functions.
This new function allows to know if the service has all the info needed to try to connect.
02c6f91 to
f54148f
Compare
Ask the service directly rather than checking the presence of a key and a URL.
f54148f to
215426b
Compare
jp9000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM™
|
A crash when using custom output was reported on Discord (https://discord.com/channels/348973006581923840/374636084883095554/1087384798894501939)
The same issue exists in |
We don't. |
|
The main problem is why no output were found. Edit: And this is not the place to discuss about that. |
Description
This PR is about the RFC 45.
Depends on:
Or if merge as is, contains:
Replace and deprecate url, key, username and password functions to replace with only one
obs_service_get_connect_info().This allow to ask the service for various connection information like:
FTL/RIST)FTL/RIST)Those info type are not bound to protocol.
Adds a function that allow the service to indicate if it has all the connection info that it needs to start streaming:
obs_service_can_try_to_connect.Motivation and Context
Part of the implementation of the RFC 45 recent changes.
How Has This Been Tested?
Only tested trying to stream SRT, might need more testing.
Types of changes
Checklist: