Skip to content

Conversation

@tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jan 19, 2023

Description

This PR is about the RFC 45.

Depends on:

Make OBS Studio rely on the notion of protocol to select the output while starting streaming rather than only asking the services.

The output id provided by the service is considered as preferred.

Motivation and Context

Part of the implementation of the RFC 45.

How Has This Been Tested?

Only testing trying to stream SRT and RIST, need more testing

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI labels Jan 19, 2023
@tytan652 tytan652 added this to the OBS Studio 29.1 milestone Jan 19, 2023
@tytan652 tytan652 force-pushed the preferred_output branch 2 times, most recently from 51478b2 to 320f692 Compare January 27, 2023 11:42
@tytan652 tytan652 force-pushed the preferred_output branch 2 times, most recently from 86add66 to 478f38b Compare January 31, 2023 07:50
@tytan652 tytan652 force-pushed the preferred_output branch 4 times, most recently from b213fd3 to da5b37d Compare February 16, 2023 14:10
@tytan652 tytan652 force-pushed the preferred_output branch 4 times, most recently from 0668417 to 97a5d88 Compare February 24, 2023 20:48
@tytan652 tytan652 force-pushed the preferred_output branch 2 times, most recently from d682549 to 9afc772 Compare March 1, 2023 09:47
@tytan652
Copy link
Collaborator Author

Remove prefix related changes as it was done in the RFC.

@tytan652 tytan652 force-pushed the preferred_output branch 7 times, most recently from d6df206 to 0788a20 Compare March 15, 2023 12:25
@tytan652 tytan652 force-pushed the preferred_output branch 5 times, most recently from 95ffa5c to c7842ed Compare March 18, 2023 23:05
@jp9000 jp9000 merged commit ea28587 into obsproject:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants