-
-
Notifications
You must be signed in to change notification settings - Fork 9k
RFC 45-4: Use protocol to select output type for streaming #8089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
247967e to
a3d9e17
Compare
6 tasks
a3d9e17 to
5607789
Compare
6 tasks
51478b2 to
320f692
Compare
86add66 to
478f38b
Compare
b213fd3 to
da5b37d
Compare
0668417 to
97a5d88
Compare
d682549 to
9afc772
Compare
9afc772 to
4a0c684
Compare
Collaborator
Author
|
Remove prefix related changes as it was done in the RFC. |
d6df206 to
0788a20
Compare
95ffa5c to
c7842ed
Compare
If the server URL is not an RTMP(S) URL, the protocol field becomes required. The output field becomes required on non-RTMP(S) services to keep backward compatibility. Also skip service if the protocol is not available.
The fallback in now inside the output.
MPEG-TS standard is not ready for AV1
c7842ed to
ea28587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about the RFC 45.
Depends on:
Make OBS Studio rely on the notion of protocol to select the output while starting streaming rather than only asking the services.
The output id provided by the service is considered as preferred.
Motivation and Context
Part of the implementation of the RFC 45.
How Has This Been Tested?
Only testing trying to stream SRT and RIST, need more testing
Types of changes
Checklist: