RFC 45-5: Allow selection of the audio codec/encoder #8090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
added
Seeking Testers
tytan652
force-pushed
the
audio_codecs
branch
4 times, most recently
from
4ed0766 to
ee0e3c5
Compare
tytan652
added
the
UI/UX
tytan652
force-pushed
the
audio_codecs
branch
2 times, most recently
from
07ee359 to
54284b0
Compare
6 tasks
tytan652
force-pushed
the
audio_codecs
branch
2 times, most recently
from
fce386d to
573b2de
Compare
tytan652
force-pushed
the
audio_codecs
branch
5 times, most recently
from
075d1ea to
f8f7163
Compare
tytan652
force-pushed
the
audio_codecs
branch
from
f8f7163 to
4f972c4
Compare
6 tasks
tytan652
force-pushed
the
audio_codecs
branch
2 times, most recently
from
007141a to
4999cbc
Compare
derrod
reviewed
Feb 24, 2023
tytan652
force-pushed
the
audio_codecs
branch
5 times, most recently
from
f7f26f2 to
8d73e25
Compare
tytan652
force-pushed
the
audio_codecs
branch
2 times, most recently
from
168848c to
7875274
Compare
tytan652
force-pushed
the
audio_codecs
branch
3 times, most recently
from
1aa2415 to
eb2fe43
Compare
If the server URL is not an RTMP(S) URL, the protocol field becomes required. The output field becomes required on non-RTMP(S) services to keep backward compatibility. Also skip service if the protocol is not available.
The fallback in now inside the output.
MPEG-TS standard is not ready for AV1
Also remove Opus-only "supported audio codecs" in the services JSON.
Also refactors AAC bitrate map too.
derrod
reviewed
Mar 19, 2023
Member
|
It's been merged 3 days ago so my remarks will be too late. Nevertheless it is unfortunate that there's been no discussion in this PR of the changes done to Simple Output Recording. They are per se outside the purview of RFC45 which deals with Protocols (and not Recording!) and should have been at the very least in a separate commit. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about the RFC 45.
Depends on:
Allow users to choose AAC or Opus to stream and record.
Stream side, codec are shown depending on the protocol used and the service compatibility.
If using different encoders in advanced, only common bitrates will be shown, this is made to avoid to over-complexify the UI.
Motivation and Context
Part of the implementation of the RFC 45.
How Has This Been Tested?
Only testing trying to stream SRT with opus and AAC, might need more testing.
Types of changes
Checklist: