-
-
Notifications
You must be signed in to change notification settings - Fork 9k
UI: Enable multiple audio tracks in Simple Output recording #6799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note to self: test Advanced Audio Properties. |
|
From internal discussions about this: Disappearing items is something we no longer want to present in OBS, so this will need to find a permanent location to live. Disabling the checkboxes might be a solution here, but we will probably need to have a larger discussion on how best to approach this from a UI/UX standpoint for the various options. Having this PR open should push those conversations forward as a high priority (at least, for myself) for post-v28 features. |
|
Can we get a radio group selection for flv (and any other formats that don't support multiple audio tracks) instead of removing the checkboxes? If we are hardcoded to track 1 for single track formats, I'd still like a radio group and simply have it disabled. |
8f95351 to
c72ac50
Compare
|
Updated the PR to implement @Fenrirthviti & @Warchamp7 suggestions. |
c72ac50 to
4250464
Compare
1d29a5b to
8270532
Compare
|
PR Updated
|
8270532 to
d91b4cd
Compare
99811c1 to
1594e13
Compare
|
Update
|
675c7b1 to
1786074
Compare
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay at a glance.
|
Approved on my end |
This adds support for multiple audio tracks in Simple Output for recordings. This is enabled for all quality presets (including "Lossless") except "Same as Stream". This is also enabled for the Replay Buffer. An exception is made for flv recording format since it only allows a single audio track. The recorded track (and streaming track) is then Track 1 as before. Signed-off-by: pkv <pkv@obsproject.com>
Per request of our UI design chief, the tracks from Standard Recording (Advanced Output) are moved below the audio encoder field. Additionally, for consistency with Simple output, the video encoder field is moved above the audio encoder (suggestion from Rodney). Signed-off-by: pkv <pkv@obsproject.com>
1786074 to
c5173d1
Compare
|
Update
|
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine at a glance.


Description
This adds support for multiple audio tracks in Simple Output for recordings. This is enabled for all quality presets (including "Lossless") except "Same as Stream".
This is also enabled for the Replay Buffer.
An exception is made for flv recording format since it only allows a single audio track.
The recorded track (and streaming track) is then Track 1 as before.
Screenshots

lossless preset:
encoded presets:

flv:

same as stream preset:

Motivation and Context
Members of obs support team report that regularly people switch from Simple to Advanced output just to be able to record multi track audio.
It would be better though for many to stick to Simple output, since it is ... simpler.
How Has This Been Tested?
Recordings made with three tracks in Simple output for:
Checked that flv & "same as stream" preset record track 1.
Types of changes
Checklist: