Skip to content

Integrate multiqcsav to pipeline#378

Merged
apeltzer merged 14 commits intonf-core:devfrom
delfiterradas:multiqcsav
Mar 26, 2026
Merged

Integrate multiqcsav to pipeline#378
apeltzer merged 14 commits intonf-core:devfrom
delfiterradas:multiqcsav

Conversation

@delfiterradas
Copy link
Copy Markdown

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@delfiterradas
Copy link
Copy Markdown
Author

@matthdsm this is a draft PR to test the changes from nf-core/modules#10320 in the demultiplex pipeline.

Some additional changes have been made to the subworkflow, but I think there are still some fixes that need to be made in the generateReadgroupBCLCONVERT function, since the test profile currently because the obtained fastq paths are incorrect

@atrigila atrigila mentioned this pull request Mar 17, 2026
@delfiterradas delfiterradas changed the title Testing integration of multiqcsav Integrate multiqcsav to pipeline Mar 19, 2026
@delfiterradas delfiterradas self-assigned this Mar 20, 2026
@delfiterradas delfiterradas marked this pull request as ready for review March 20, 2026 17:40
@delfiterradas delfiterradas requested a review from a team as a code owner March 20, 2026 17:40
@delfiterradas delfiterradas requested review from glichtenstein and removed request for a team March 20, 2026 17:40
@delfiterradas delfiterradas linked an issue Mar 20, 2026 that may be closed by this pull request
@delfiterradas delfiterradas requested a review from grst March 25, 2026 12:30
@apeltzer apeltzer requested review from apeltzer and removed request for glichtenstein March 26, 2026 13:36
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delfiterradas - looks great and report is there as far as I can see in the test run :-)

@apeltzer apeltzer merged commit 17a49d7 into nf-core:dev Mar 26, 2026
88 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reintegrate the multiqc_sav module into the pipeline

2 participants