Skip to content

Enable workflow outputs#379

Merged
apeltzer merged 38 commits intonf-core:devfrom
atrigila:workflow_outputs
Mar 18, 2026
Merged

Enable workflow outputs#379
apeltzer merged 38 commits intonf-core:devfrom
atrigila:workflow_outputs

Conversation

@atrigila
Copy link
Copy Markdown
Contributor

@atrigila atrigila commented Mar 6, 2026

Closes #367

@atrigila
Copy link
Copy Markdown
Contributor Author

atrigila commented Mar 6, 2026

@nf-core-bot fix linting

@atrigila atrigila marked this pull request as ready for review March 9, 2026 13:38
@atrigila atrigila requested a review from a team as a code owner March 9, 2026 13:38
@atrigila atrigila requested review from apeltzer and kobelavaerts and removed request for a team March 9, 2026 13:38
@atrigila
Copy link
Copy Markdown
Contributor Author

atrigila commented Mar 9, 2026

Moving this back to draft to keep polishing the missing and extra files

@atrigila atrigila marked this pull request as draft March 9, 2026 14:43
@atrigila
Copy link
Copy Markdown
Contributor Author

atrigila commented Mar 16, 2026

The mkfastq test stopped working, I think when it fetches the remote files. It will stay in Staging foreign file: https://cf.10xgenomics.com/supp/cell-exp/cellranger-tiny-bcl-1.2.0.tar.gz forever.

@atrigila
Copy link
Copy Markdown
Contributor Author

I had to patch bcl_demultiplex because it is currently being changed / worked on to include multiqcsav. The patch will be removed and the changes will be applied in: #378

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with sgdemux (and sgdemux's flowcell) tests:

sgdemux in this test basically reads from the fastq directory and writes the output files in the same directory:

sgdemux \
    --sample-metadata out.sample_meta.csv \
    --fastqs sim-data \
    --output-dir sim-data \
    --demux-threads 4 \
    --compressor-threads 4 \
    --writer-threads 4 \

So that's why there are some extra files:

  • The files prefixed with out such as out_L001_R1_001.fastq.gz are the input fastq files.
  • The files such as s10_S10_L001_R1_001.fastq.gz and s10_S10_L001_R2_001.fastq.gz are the produced output files.
  • The module does not differentiate capturing between undetermined and regular fastq, so that's why undetermined fastq (such as Undetermined_S25_L001_R1_001.fastq.gz) also appear (and flow into fastp).

So with workflow outputs we are now capturing everything from sample_fastq and that's why we see more files in the snapshot. Changing (basically, improving) the module to separate between input fastq, output fastq and undetermined will also change this snapshot (all the undetermined fastp results will also dissapear), so, in order for the changes not to be so big, I would merge this as-is and then do a whole refactoring of the sgdemux module and the outputs that are then captured in the workflow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked here: #380

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree on that approach 👍🏻

@atrigila atrigila marked this pull request as ready for review March 17, 2026 15:39
@atrigila atrigila requested review from apeltzer and removed request for apeltzer March 17, 2026 15:40
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, follow up issues are tracked accordingly, nice :-)

@apeltzer apeltzer merged commit a0693e8 into nf-core:dev Mar 18, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants