Remove checkIfExists from interop file resolution#10942
Merged
delfiterradas merged 5 commits intonf-core:masterfrom Mar 19, 2026
Merged
Remove checkIfExists from interop file resolution#10942delfiterradas merged 5 commits intonf-core:masterfrom
delfiterradas merged 5 commits intonf-core:masterfrom
Conversation
SPPearce
reviewed
Mar 18, 2026
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
Why do you not want to check the files exist?
Contributor
Author
@SPPearce Because there is a test that fails in the demultiplex pipeline because the input doesn't have InterOp files. However, if we remove the check, |
SPPearce
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Required for nf-core/demultiplex#378
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda