Skip to content

Local testing with LocalStack #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nishu-builder wants to merge 3 commits into
base: nishad/job-runner-watcher
Choose a base branch
from
Draft

Local testing with LocalStack #4949

nishu-builder wants to merge 3 commits into from
+260 −27

Conversation

@nishu-builder
Copy link
Contributor

@nishu-builder nishu-builder commented Jan 17, 2026 •
edited
Loading

LocalStack + eval-jobs namespace for local S3 testing.

This was referenced Jan 17, 2026
Draft
Draft
Draft
Draft
@nishu-builder Graphite App
Copy link
Contributor Author

nishu-builder commented Jan 17, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nishu-builder nishu-builder mentioned this pull request Jan 17, 2026
Draft
@nishu-builder nishu-builder changed the title Add LocalStack and eval-jobs namespace for local S3 testing Local testing with LocalStack Jan 17, 2026
@nishu-builder nishu-builder marked this pull request as ready for review January 17, 2026 00:42
@nishu-builder nishu-builder mentioned this pull request Jan 17, 2026
Closed
@blacksmith-sh
Copy link

blacksmith-sh bot commented Jan 17, 2026 •
edited
Loading

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.cc View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.cc View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.h View Logs
EditionsCodegenTests/third_party/protobuf/editions/golden/simple_proto3.pb.h View Logs

Fix in Cursor

@datadog-official
Copy link

datadog-official bot commented Jan 17, 2026 •
edited
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 2 Tests failed

test_generate_presigned_get_url from test_presigned.py (Datadog) (Fix with Cursor) 
Unable to locate credentials

    test_generate_presigned_put_url from test_presigned.py (Fix with Cursor)

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 849a89b | Docs | Was this helpful? Give us feedback!

@nishu-builder nishu-builder marked this pull request as draft January 17, 2026 00:53
graphite-app[bot]
graphite-app bot reviewed Jan 17, 2026
View reviewed changes
app_backend/src/metta/app_backend/job_runner/dispatcher.py
Comment on lines 10 to 13
from metta.app_backend.job_runner.config import (
JOB_NAMESPACE,
LABEL_APP,
LABEL_APP_VALUE,
LABEL_JOB_ID,
Copy link
Contributor

@graphite-app graphite-app bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement needs to be updated to remove the JOB_NAMESPACE import and add get_dispatch_config since it's used to access the config.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

app_backend/src/metta/app_backend/job_runner/watcher.py
Comment on lines 21 to 24
from metta.app_backend.job_runner.config import (
JOB_NAMESPACE,
LABEL_APP,
LABEL_APP_VALUE,
LABEL_JOB_ID,
Copy link
Contributor

@graphite-app graphite-app bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement needs to be updated to remove the JOB_NAMESPACE import and add get_dispatch_config since it's used to access the config.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@nishu-builder nishu-builder force-pushed the nishad/job-runner-local branch from 63fe7fb to b7d0e5c Compare January 17, 2026 01:07
@nishu-builder nishu-builder force-pushed the nishad/job-runner-watcher branch from 4dfb22d to 21539ab Compare January 17, 2026 01:07
@nishu-builder nishu-builder mentioned this pull request Jan 17, 2026
Closed
@graphite-app graphite-app bot force-pushed the nishad/job-runner-watcher branch from 21539ab to 9dd7def Compare January 17, 2026 01:13
@graphite-app graphite-app bot force-pushed the nishad/job-runner-local branch from b7d0e5c to 8e02bc7 Compare January 17, 2026 01:14
@nishu-builder nishu-builder force-pushed the nishad/job-runner-local branch from 8e02bc7 to d1a5bdf Compare January 17, 2026 02:39
Nishad and others added 3 commits January 16, 2026 18:45
@claude
Add LocalStack and eval-jobs namespace for local S3 testing
5eab8ca 
- Add LocalStack process to process-compose.yaml
- Add eval-jobs namespace alongside jobs namespace
- Make JOB_NAMESPACE configurable via config
- Add --s3 flag to server and watcher commands
- Update help text with S3 mode instructions

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Fix presigned URLs to use host.docker.internal for k8s access
696ebbe 
Server uses host.docker.internal:4566 so presigned URLs work from pods.
Watcher uses localhost:4566 since it runs on host.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add integration tests for presigned URL flow
849a89b
@nishu-builder nishu-builder force-pushed the nishad/job-runner-watcher branch from 93926b7 to 1866c8d Compare January 17, 2026 02:47
@nishu-builder nishu-builder force-pushed the nishad/job-runner-local branch from 11be74c to 849a89b Compare January 17, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nishu-builder