-
Notifications
You must be signed in to change notification settings - Fork 47
Dispatcher presigned URL generation #4947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nishad/job-runner-episode
Are you sure you want to change the base?
Dispatcher presigned URL generation #4947
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acff8976e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| import requests | ||
|
|
||
| spec_to_write = {**job_spec, "policy_uris": urls["policy_uris"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve policy_uris when building presigned spec
When EVAL_S3_BUCKET is set, the uploaded spec replaces the job’s policy_uris with urls["policy_uris"], but policy_s3_paths is currently initialized as an empty list in this branch. That means any job that originally had policy URIs will be serialized with an empty policy_uris, and PureSingleEpisodeJob validation will fail because assignments must be within the policy range. This breaks all presigned runs that have non-empty policies; you likely need to derive policy_s3_paths from job_spec["policy_uris"] (or fall back to the original list) before overwriting the spec.
Useful? React with 👍 / 👎.
acff897 to
83392ef
Compare
50db0b2 to
68bc75b
Compare
68bc75b to
3c8cb04
Compare
83392ef to
6bc5ab2
Compare
6bc5ab2 to
abc4a14
Compare
3c8cb04 to
d11d042
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
abc4a14 to
caa2aa9
Compare

Generate presigned URLs in dispatcher when EVAL_S3_BUCKET configured.