Skip to content

Conversation

@nishu-builder
Copy link
Contributor

@nishu-builder nishu-builder commented Jan 17, 2026

Generate presigned URLs in dispatcher when EVAL_S3_BUCKET configured.

Copy link
Contributor Author

nishu-builder commented Jan 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nishu-builder nishu-builder changed the title Add eval account S3 config to dispatcher Dispatcher presigned URL generation Jan 17, 2026
@nishu-builder nishu-builder marked this pull request as ready for review January 17, 2026 00:42
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acff8976e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


import requests

spec_to_write = {**job_spec, "policy_uris": urls["policy_uris"]}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve policy_uris when building presigned spec

When EVAL_S3_BUCKET is set, the uploaded spec replaces the job’s policy_uris with urls["policy_uris"], but policy_s3_paths is currently initialized as an empty list in this branch. That means any job that originally had policy URIs will be serialized with an empty policy_uris, and PureSingleEpisodeJob validation will fail because assignments must be within the policy range. This breaks all presigned runs that have non-empty policies; you likely need to derive policy_s3_paths from job_spec["policy_uris"] (or fall back to the original list) before overwriting the spec.

Useful? React with 👍 / 👎.

@nishu-builder nishu-builder marked this pull request as draft January 17, 2026 00:53
@nishu-builder nishu-builder force-pushed the nishad/job-runner-dispatcher branch from acff897 to 83392ef Compare January 17, 2026 01:07
@nishu-builder nishu-builder force-pushed the nishad/job-runner-episode branch from 50db0b2 to 68bc75b Compare January 17, 2026 01:07
@graphite-app graphite-app bot force-pushed the nishad/job-runner-episode branch from 68bc75b to 3c8cb04 Compare January 17, 2026 01:12
@graphite-app graphite-app bot force-pushed the nishad/job-runner-dispatcher branch from 83392ef to 6bc5ab2 Compare January 17, 2026 01:13
@nishu-builder nishu-builder force-pushed the nishad/job-runner-dispatcher branch from 6bc5ab2 to abc4a14 Compare January 17, 2026 02:39
@nishu-builder nishu-builder force-pushed the nishad/job-runner-episode branch from 3c8cb04 to d11d042 Compare January 17, 2026 02:39
@nishu-builder nishu-builder force-pushed the nishad/job-runner-dispatcher branch from abc4a14 to caa2aa9 Compare January 17, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants