S3 presigned URL utilities #4945
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nishu-builder
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab29f5c5dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def test_generate_presigned_put_url(): | ||
| url = generate_presigned_put_url( | ||
| bucket="test-bucket", | ||
| key="jobs/123/results.json", | ||
| expiration_seconds=3600, | ||
| ) |
There was a problem hiding this comment.
These tests call generate_presigned_*_url without stubbing credentials. boto3 signs the request and raises NoCredentialsError when no AWS credentials are configured, which is the typical case in CI and local dev; the same issue applies to both tests. Consider injecting dummy credentials (e.g., via env), stubbing the client, or monkeypatching boto3.client so the tests don’t fail outside AWS-enabled environments.
Useful? React with 👍 / 👎.
nishu-builder
force-pushed
the
nishad/job-runner-s3-utils
branch
from
ab29f5c to
ca526a7
Compare
nishu-builder
force-pushed
the
nishad/job-runner-spec
branch
from
50631d9 to
138b684
Compare
graphite-app
bot
force-pushed
the
nishad/job-runner-spec
branch
2 times, most recently
from
be9f9ad to
4c5f5f2
Compare
graphite-app
bot
force-pushed
the
nishad/job-runner-s3-utils
branch
from
ca526a7 to
92a4fd1
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nishu-builder
force-pushed
the
nishad/job-runner-s3-utils
branch
from
92a4fd1 to
e19544d
Compare
nishu-builder
force-pushed
the
nishad/job-runner-spec
branch
from
4c5f5f2 to
a7c4b35
Compare
Helper functions for generating presigned S3 URLs.