Episode runner presigned URL support #4946
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nishu-builder
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50db0b2922
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
metta/sim/single_episode_runner.py
Outdated
| result = subprocess.run( | ||
| [sys.executable, "-m", "metta.sim.pure_single_episode_runner", temp_file.name], |
There was a problem hiding this comment.
When JOB_SPEC_URI is set, the subprocess is launched with -m metta.sim.pure_single_episode_runner, but this repository only provides alo.pure_single_episode_runner. As written, the subprocess will exit with ModuleNotFoundError, so presigned URL jobs never run. Point the call at the existing module (or add the missing module) to make the new mode functional.
Useful? React with 👍 / 👎.
nishu-builder
force-pushed
the
nishad/job-runner-s3-utils
branch
from
ab29f5c to
ca526a7
Compare
nishu-builder
force-pushed
the
nishad/job-runner-episode
branch
from
50db0b2 to
68bc75b
Compare
graphite-app
bot
force-pushed
the
nishad/job-runner-s3-utils
branch
from
ca526a7 to
92a4fd1
Compare
graphite-app
bot
force-pushed
the
nishad/job-runner-episode
branch
from
68bc75b to
3c8cb04
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nishu-builder
force-pushed
the
nishad/job-runner-s3-utils
branch
from
92a4fd1 to
e19544d
Compare
nishu-builder
force-pushed
the
nishad/job-runner-episode
branch
from
3c8cb04 to
d11d042
Compare
Add presigned URL mode to episode runner for cross-account isolation.