Remove redundant gazelle exclusions (**/build) and fix setup inconsistencies

[rdesgroppes]

What does this PR do?

Remove gazelle exclusions that had to be put in place pending a fix for gazelle confused by build directories on "broken" case-insensitive filesystem stacks (docker/desktop-feedback#251).
Doing so, I realized there were inconsistencies in the gazelle setup and took the opportunity to fix them.

Motivation

#48455 indeed allows to get rid of the following exclusions:

# TODO(agent-build): This exclusion is ready for removal, blocked by issues caused by the interaction of
# Bazel with directories named `build` created by the CMake builds. We can remove this once we remove CMake
# support or we upgrade to a Bazel version containing a fix: https://github.com/bazelbuild/bazel/pull/26842
# In the meantime, temporarily remove this exclusion locally if regeneration of BUILD files is required
# gazelle:exclude rtloader
...
# gazelle:exclude .gitlab

Nearby inconsistencies in the gazelle setup:

• build_tags is passed by attribute (build_tags = ALL_BUILD_TAGS) => OK (canonical),
• external was passed by args (-external=static) => pass by attribute (external = "static"),
• prefix was passed by directive (# gazelle:prefix github.com/DataDog/datadog-agent) => pass by attribute (prefix = "github.com/DataDog/datadog-agent"),
• args happens to be a compatibility shim => use extra_args (canonical) when there's no corresponding attribute yet:
  • build_file_name was passed by args and doesn't have a corresponding attribute yet => pass by extra_args,
  • strict was passed from a single GitLab job and doesn't have a corresponding attribute yet => pass by extra_args.

Describe how you validated your changes

Kind assistance of @alopezz and/or @JSGette who run Linux containers on their macOS-powered laptop.

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor 4035f3a4:

Results for datadog-agent_7.79.0~devel.git.240.472f7ed.pipeline.104804549-1_amd64.deb:

No change detected

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4035f3a
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.636 MiB
✅	agent_deb_amd64_fips	709.650 MiB
✅	agent_heroku_amd64	313.317 MiB
✅	agent_msi	604.822 MiB
✅	agent_rpm_amd64	752.620 MiB
✅	agent_rpm_amd64_fips	709.634 MiB
✅	agent_rpm_arm64	731.051 MiB
✅	agent_rpm_arm64_fips	691.078 MiB
✅	agent_suse_amd64	752.620 MiB
✅	agent_suse_amd64_fips	709.634 MiB
✅	agent_suse_arm64	731.051 MiB
✅	agent_suse_arm64_fips	691.078 MiB
✅	docker_agent_amd64	812.935 MiB
✅	docker_agent_arm64	816.140 MiB
✅	docker_agent_jmx_amd64	1003.850 MiB
✅	docker_agent_jmx_arm64	995.834 MiB
✅	docker_cluster_agent_amd64	203.946 MiB
✅	docker_cluster_agent_arm64	218.420 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.238 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.881 MiB
✅	dogstatsd_deb_arm64	28.034 MiB
✅	dogstatsd_rpm_amd64	29.881 MiB
✅	dogstatsd_suse_amd64	29.881 MiB
✅	iot_agent_deb_amd64	43.289 MiB
✅	iot_agent_deb_arm64	40.340 MiB
✅	iot_agent_deb_armhf	41.087 MiB
✅	iot_agent_rpm_amd64	43.290 MiB
✅	iot_agent_suse_amd64	43.290 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-14.66 KiB (0.01% reduction)	174.782 → 174.767 → 178.360
✅	agent_deb_amd64_fips	+34.26 KiB (0.02% increase)	165.303 → 165.336 → 172.790
✅	agent_heroku_amd64	neutral	75.005 MiB → 79.970
✅	agent_msi	-16.0 KiB (0.01% reduction)	138.395 → 138.379 → 146.220
✅	agent_rpm_amd64	+60.55 KiB (0.03% increase)	177.524 → 177.583 → 181.830
✅	agent_rpm_amd64_fips	+8.18 KiB (0.00% increase)	167.627 → 167.635 → 173.370
✅	agent_rpm_arm64	-82.41 KiB (0.05% reduction)	159.526 → 159.446 → 163.060
✅	agent_rpm_arm64_fips	-13.45 KiB (0.01% reduction)	151.375 → 151.362 → 156.170
✅	agent_suse_amd64	+60.55 KiB (0.03% increase)	177.524 → 177.583 → 181.830
✅	agent_suse_amd64_fips	+8.18 KiB (0.00% increase)	167.627 → 167.635 → 173.370
✅	agent_suse_arm64	-82.41 KiB (0.05% reduction)	159.526 → 159.446 → 163.060
✅	agent_suse_arm64_fips	-13.45 KiB (0.01% reduction)	151.375 → 151.362 → 156.170
✅	docker_agent_amd64	neutral	268.112 MiB → 272.480
✅	docker_agent_arm64	neutral	255.332 MiB → 261.060
✅	docker_agent_jmx_amd64	neutral	336.763 MiB → 341.100
✅	docker_agent_jmx_arm64	neutral	319.960 MiB → 325.620
✅	docker_cluster_agent_amd64	neutral	71.377 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	67.013 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.175 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.494 MiB → 14.830
✅	dogstatsd_deb_amd64	+2.26 KiB (0.03% increase)	7.893 → 7.895 → 8.790
✅	dogstatsd_deb_arm64	neutral	6.779 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.905 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.905 MiB → 8.800
✅	iot_agent_deb_amd64	+2.59 KiB (0.02% increase)	11.403 → 11.406 → 12.040
✅	iot_agent_deb_arm64	neutral	9.702 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.943 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.417 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.417 MiB → 12.060

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 426e3bd2-8006-479d-a1ba-d85b0e63e671

Baseline: 8b5150a
Comparison: f0055cf
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-4.50	[-7.39, -1.60]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.51	[+1.36, +1.67]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.36	[+0.30, +0.42]	1	Logs
➖	quality_gate_idle	memory utilization	+0.25	[+0.20, +0.30]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.19	[+0.00, +0.37]	1	Logs
➖	file_tree	memory utilization	+0.07	[+0.01, +0.13]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.05	[-0.17, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.07, +0.09]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.11, +0.11]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.21, +0.20]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.43, +0.40]	1	Logs
➖	docker_containers_memory	memory utilization	-0.01	[-0.09, +0.06]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.40, +0.37]	1	Logs
➖	ddot_logs	memory utilization	-0.05	[-0.11, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.12	[-0.62, +0.38]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.20	[-0.36, -0.03]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.22	[-0.26, -0.18]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.22	[-0.46, +0.01]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.37	[-0.54, -0.21]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.46	[-0.56, -0.37]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.57	[-0.71, -0.43]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.54	[-3.17, +0.09]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-4.50	[-7.39, -1.60]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	692 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	271.90MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	682 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
❌	quality_gate_idle	memory_usage	9/10	175.88MiB > 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	490.78MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	209.85MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	347.27 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	417.50MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

bazel:run-gazelle

  bazel:run-gazelle:
    after_script:
    - "if [ $CI_JOB_STATUS = failed ]; then\n  echo >&2 \"\U0001F4A1 To fix the above\
      \ problem, please consider running the following command:\"\n  echo >&2 \"$FIX_COMMAND\"\
      \nfi"
    cache:
    - key:
        files:
        - .bazelversion
        prefix: bazelversion-$CI_RUNNER_DESCRIPTION
      paths:
      - .cache/bazelisk
      - .cache/bazel/*/install
      policy: pull$BAZEL_CACHE_POLICY_SUFFIX
      when: on_success
    - key:
        files:
        - .go-version
        - .python-version
        prefix: bazel-$CI_JOB_NAME
      paths:
      - .cache/bazel/*/cache
      - .cache/go
      - .cache/ms-go
      - .cache/pip
      policy: pull$BAZEL_CACHE_POLICY_SUFFIX
      when: on_success
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
    needs: []
    script:
-   - bazel run //:gazelle -- -mode=diff -strict
?                                       --------
+   - bazel run //:gazelle -- -mode=diff
    stage: lint
    tags:
    - arch:amd64
    - specific:true
    variables:
      BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
      FIX_COMMAND: bazel run //:gazelle
      KUBERNETES_CPU_REQUEST: 4
      KUBERNETES_MEMORY_LIMIT: 12Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      XDG_CACHE_HOME: $CI_PROJECT_DIR/.cache

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

[aiuto]

Seems like it is worth keeping because we should never have code in .gitlab.

[rdesgroppes]

Good news: gazelle honors both the good old .bazelignore and the more recent ignore_directories in REPO.bazel (Bazel 8.0), see:

func newIgnoreFilter(repoRoot string) *ignoreFilter {
	bazelignorePaths, err := loadBazelIgnore(repoRoot)
	if err != nil {
		log.Printf("error loading .bazelignore: %v", err)
	}

	repoDirectoryIgnores, err := loadRepoDirectoryIgnore(repoRoot)

I'll therefore file a PR to extend the 2nd as a preferred point of maintenance (supports globs):

datadog-agent/REPO.bazel

Lines 1 to 6 in 8b5150a

	ignore_directories([
	"**/build", # avoid BUILD/build mess: https://github.com/docker/desktop-feedback/issues/251
	".cache", # in-workspace cache: GitLab jobs, GitHub actions
	"bazel-*", # bazel convenience symlinks: suddenly caused issues inside arm64 Linux containers
	"target", # cargo build creates it where Cargo.toml lives
	])

[rdesgroppes]

Here you go:

• Extend REPO.bazel ignored directories to all "hidden" roots #48525.