Extend REPO.bazel ignored directories to all "hidden" roots#48525
Conversation
### What does this PR do? Replace the single `.cache` entry in `ignore_directories` with a `.*` glob that matches all "hidden" root directories at once. ### Motivation Several "hidden" directories live at the repo root, such as: - .cache [1.] - .claude - .cursor - .dda - .ddqa - .git - .github - .gitlab [2.] - .idea - .mypy_cache - .ruff_cache - .run - .vscode - etc. Each one risks confusing `bazel`'s directory watcher and/or `gazelle`'s scope, and the list keeps growing as new tools drop directories there. The `.*` glob covers all of them without requiring future additions, including: 1. `.cache`, which was already listed, 2. `.gitlab`, thus honoring #48279 (comment) The exclusions are of course honored by `bazel` itself, but also by `gazelle` ([source](https://github.com/bazel-contrib/bazel-gazelle/blob/4a7caee10fbd2da9bb059f3ce7c2cac8d0050e53/walk/config.go#L211-L217)) and probably others.
Files inventory check summaryFile checks results against ancestor f0055cf9: Results for datadog-agent_7.79.0~devel.git.249.d40616f.pipeline.104858976-1_amd64.deb:No change detected |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3ea054e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.06 | [-2.95, +3.06] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.42 | [+1.17, +1.66] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.92 | [-0.67, +2.52] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.63 | [+0.46, +0.79] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.54 | [+0.39, +0.68] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.16 | [+0.10, +0.21] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.13 | [-0.03, +0.29] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.06 | [-2.95, +3.06] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.41, +0.43] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.01 | [-0.04, +0.06] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.20, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.21] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.00 | [-0.17, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.39, +0.38] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.13, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.10, +0.05] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.08 | [-0.57, +0.41] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.14 | [-0.18, -0.10] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.21 | [-0.44, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.38 | [-0.45, -0.32] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.59 | [-0.66, -0.53] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.64 | [-0.75, -0.53] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -1.09 | [-1.22, -0.95] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -2.61 | [-2.73, -2.49] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 703 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 272.14MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 682 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.59MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 492.93MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 206.11MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 358.12 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 413.15MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
Replace the single
.cacheentry inignore_directoriesofREPO.bazelwith a.*glob that matches all "hidden" directories at the root of the workspace.Motivation
Several "hidden" directories live at the repo root, such as:
Each one risks confusing
bazel's directory watcher and/orgazelle's scope, and the list keeps growing as new tools drop directories there.The
.*glob covers all of them without requiring future additions, including:.cache, which was already listed,.gitlab, thus honoring Remove redundantgazelleexclusions (**/build) and fix setup inconsistencies #48279 (comment)Additional Notes
Such exclusions are of course used by
bazelitself, but also bygazelle(source) and probably other tools of the Bazel ecosystem.