input.fileDialogOpened + unhandledPromptBehavior:file#883
input.fileDialogOpened + unhandledPromptBehavior:file#883sadym-chromium merged 23 commits intomainfrom
input.fileDialogOpened + unhandledPromptBehavior:file#883Conversation
+ remove picker type + check prompt handler through all the sessions
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
cf917e3 to
fa27cff
Compare
juliandescottes
left a comment
There was a problem hiding this comment.
just 2 nits otherwise lgtm
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
input.fileDialogOpened + `unhandledPromptBehavior:file
input.fileDialogOpened + `unhandledPromptBehavior:fileinput.fileDialogOpened + unhandledPromptBehavior:file
SHA: 3c02257 Reason: push, by sadym-chromium Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@juliandescottes PTAL on the w3c/webdriver#1884 |
Implementation of w3c/webdriver-bidi#883
|
@sadym-chromium when filling out the BiDi status spreadsheet I stumbled over this PR and the question if we actually want to have a Given that you already have |
I can be mistaken, but from what I remember, dismissing file dialogs is not possible in some OS. I think current functionality covers all the scenario we are aware of, and we don't need |
Hm, so we basically have the event |
Showing or not the file dialog depends on the "unhandledPromptBehavior:file" capability, and the event is emitted regardless of that. |
Lets see where we end-up when we are going to implement the file open dialog support. We will reporter back then. |
This PR implements
input.fileDialogOpenedevent and definesunhandledPromptBehaviorforfile. It should be accompanied by the following changes:HTML spec: whatwg/html#11030
WebDriver Classic spec: w3c/webdriver#1884
File system access: WICG/file-system-access#452
Open questions:
browsingContext.userPromptOpened? If so, there will be no way of subscribing only forinput.fileDialogOpenedevent. Also, file dialogs are specific, as it does not supportbrowsingContext.handleUserPrompt.Re-imagining the #568, addressing #494.
Preview | Diff